Hi Thuan,
In normal runing/condition the message not printed. So it can not be considered
as spam.
B.R/Thnag
-----Original Message-----
From: Thuan Tran <thuan.t...@dektech.com.au>
Sent: Thursday, March 5, 2020 5:25 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Gary Lee
<gary....@dektech.com.au>; Minh Hon Chau <minh.c...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] fm: ignore unexpected event on standby node [#3017]
Hi Thang,
ACK with minor comment.
Best Regards,
ThuanTr
-----Original Message-----
From: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>
Sent: Thursday, March 5, 2020 3:48 PM
To: Gary Lee <gary....@dektech.com.au>; Minh Hon Chau
<minh.c...@dektech.com.au>; Thuan Tran <thuan.t...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
<thang.d.ngu...@dektech.com.au>
Subject: [PATCH 1/1] fm: ignore unexpected event on standby node [#3017]
In roaming sc, when the standby SC down, the new standby is selected. But the
amfd on the old standby is stuck.
And the new standby receives the amfd down event of old standby.
In this case, FM should ignore events from old standby SC.
---
src/fm/fmd/fm_mds.cc | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/fm/fmd/fm_mds.cc b/src/fm/fmd/fm_mds.cc index
c5b3581ee..755856e2d 100644
--- a/src/fm/fmd/fm_mds.cc
+++ b/src/fm/fmd/fm_mds.cc
@@ -434,6 +434,14 @@ static uint32_t fm_mds_svc_evt(FM_CB *cb,
return NCSCC_RC_FAILURE;
}
+ if ((cb->role == PCS_RDA_STANDBY) && cb->peer_sc_up) {
+ if (svc_evt->i_node_id != cb->peer_node_id) {
+ LOG_NO("Ignore event of node %x. Peer node is %x",
+ (unsigned)svc_evt->i_node_id, (unsigned)cb->peer_node_id);
[Thuan] Will it spam syslog? I think it should be TRACE()
+ return NCSCC_RC_SUCCESS;
+ }
+ }
+
switch (svc_evt->i_change) {
case NCSMDS_DOWN:
switch (svc_evt->i_svc_id) {
--
2.17.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
