Hi Thuan,
Thanks for your comments.
Best Regards,
ThienHuynh
-----Original Message-----
From: Thuan Tran <thuan.t...@dektech.com.au>
Sent: Wednesday, May 13, 2020 3:40 PM
To: Thien Minh Huynh <thien.m.hu...@dektech.com.au>; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] log: increase sleep 2s to make sure all directory are
created successfully [#3187]
Hi Thien,
ACK with minor comment that maybe change short message to have quick catchup
what the fix is For example:
log: improve robustness for apitest suite 5 test case 16 [#3187]
Sleep 1s after change logRootDirectory not enough time to logsv processing of
directories creation. So cannot access '/srv/shared/saflog/croot/testRoot'.
Increase sleep 2s to make sure all directory are created successfully.
Best Regards,
ThuanTr
-----Original Message-----
From: Thien Minh Huynh <thien.m.hu...@dektech.com.au>
Sent: Wednesday, May 13, 2020 2:35 PM
To: Thuan Tran <thuan.t...@dektech.com.au>; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
<thien.m.hu...@dektech.com.au>
Subject: [PATCH 1/1] log: increase sleep 2s to make sure all directory are
created successfully [#3187]
Sleep 1s after change logRootDirectory not enough time to logsv processing of
directories creation. So cannot access '/srv/shared/saflog/croot/testRoot'
The fix is increase sleep time to 2s to make sure all directory are created
successfully.
---
src/log/apitest/tet_LogOiOps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/log/apitest/tet_LogOiOps.c b/src/log/apitest/tet_LogOiOps.c
index aae0d5c57..2fde9b5d4 100644
--- a/src/log/apitest/tet_LogOiOps.c
+++ b/src/log/apitest/tet_LogOiOps.c
@@ -1729,7 +1729,7 @@ void change_root_path(void)
}
// Verify if the directory and subdirectly are created successfully
- sleep(1); // to make sure logsv done processing of directories creation
+ sleep(2); // to make sure logsv done processing of directories
+creation
sprintf(command, "ls %s/testRoot 1>/dev/null", tstdir);
rc = systemCall(command);
if (rc != 0) {
--
2.17.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
