Hi Thang, OK, will move it up before push.
Best Regards, ThuanTr -----Original Message----- From: Thang Duc Nguyen <[email protected]> Sent: Monday, May 18, 2020 11:34 AM To: Thuan Tran <[email protected]>; Minh Hon Chau <[email protected]> Cc: [email protected] Subject: RE: [PATCH 1/1] osaf: fix coding issue identified by codechecker [#3189] Hi Thuan, Just a minor comment. Instead of adding asset() below size = (size + 3) & ~3; It's better to move it to above. B.R/Thang -----Original Message----- From: Thuan Tran <[email protected]> Sent: Monday, May 18, 2020 11:15 AM To: Thang Duc Nguyen <[email protected]>; Minh Hon Chau <[email protected]> Cc: [email protected]; Thuan Tran <[email protected]> Subject: [PATCH 1/1] osaf: fix coding issue identified by codechecker [#3189] --- src/osaf/immutil/immutil.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/osaf/immutil/immutil.c b/src/osaf/immutil/immutil.c index e10a8ffdf..4ad7a8fe8 100644 --- a/src/osaf/immutil/immutil.c +++ b/src/osaf/immutil/immutil.c @@ -1048,6 +1048,7 @@ static void *clistMalloc(struct Chunk *clist, size_t size) struct Chunk *chunk; size = (size + 3) & ~3; + osafassert(clist); if (size > CHUNK) { chunk = newChunk(clist->next, size); -- 2.17.1 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
