Summary: imm: reboot nodes used to be different partition with coord [#2936]
Review request for Ticket(s): 2936
Peer Reviewer(s): Minh, Thang, Vu
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2936
Base revision: d28ee50720d5e57edba6ee5c27e8b2bebb0638fa
Personal repository: git://git.code.sf.net/u/thuantr/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
N/A
revision 40ff2641bbfd5caf8133f9c3a256b1f3268d5f92
Author: thuan.tran <thuan.t...@dektech.com.au>
Date: Fri, 3 Jul 2020 16:24:47 +0700
imm: define macro for values of canBeCoord [#2936]
revision c1da24ed55b18fd511acbab2e2edac9bb9073dd4
Author: thuan.tran <thuan.t...@dektech.com.au>
Date: Fri, 3 Jul 2020 16:24:47 +0700
imm: reboot nodes used to be different partition with coord [#2936]
- immnd send re-introduce refresh=3 with ex-immd (active) node id.
- immd set very high priority for re-introduce msg of local immnd
and choose coord if re-introduce refresh=3 from local immnd.
- immd reply re-intro to reboot if ex-immd is not same as ex-immd
of selected coord.
- immd use new INTRO_RSP_2 to checkpoint ex-immd to standby.
- immnd use MDS_RED_SUBSCRIBE for immd to know active/standby immd
and help detect headless in multi partition clusters rejoin.
- immnd discard FEVS from unknown immd or during re-introduce to
avoid immnd OUT OF ORDER restart and lost ex-immd info.
- Update README.SC_ABSENCE for this new feature.
- Allow to configure disable/enable this new feature.
- immd standby will reboot if see two actives immd to avoid sync
with wrong active.
Complete diffstat:
------------------
scripts/opensaf_reboot | 1 +
src/imm/README.SC_ABSENCE | 21 +++++++
src/imm/common/immsv_evt.c | 17 +++++-
src/imm/common/immsv_evt.h | 15 ++++-
src/imm/immd/immd.conf | 7 +++
src/imm/immd/immd.h | 10 ++++
src/imm/immd/immd_cb.h | 3 +
src/imm/immd/immd_evt.c | 141 +++++++++++++++++++++++++++------------------
src/imm/immd/immd_main.c | 9 +++
src/imm/immd/immd_mbcsv.c | 24 ++++++--
src/imm/immd/immd_mds.c | 17 ++++--
src/imm/immd/immd_proc.c | 26 ++++-----
src/imm/immd/immd_red.h | 1 +
src/imm/immd/immd_sbevt.c | 24 +++++---
src/imm/immnd/immnd_cb.h | 3 +
src/imm/immnd/immnd_evt.c | 88 ++++++++++++++++++++++------
src/imm/immnd/immnd_main.c | 2 +
src/imm/immnd/immnd_mds.c | 35 ++++++++---
src/imm/immnd/immnd_proc.c | 19 +++---
19 files changed, 336 insertions(+), 127 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK by reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
