Hi Thuan,
Thanks for your comments.
Best Regards,
Phuc Chau
-----Original Message-----
From: Thuan Tran
Sent: Thursday, July 9, 2020 04:01 PM
To: Phuc Hoang Chau <phuc.h.c...@dektech.com.au>; Thang Duc Nguyen
<thang.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] imm: fix memory leak reeported by valgrind [#3199]
Hi Phuc,
For consistent code, could you please use?
m_MMGR_FREE_BUFR_LIST(uba.start);
Also, I think need also fix in function immd_pending_discards().
Best Regards,
ThuanTr
-----Original Message-----
From: Phuc Hoang Chau <phuc.h.c...@dektech.com.au>
Sent: Thursday, July 9, 2020 2:34 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thuan Tran
<thuan.t...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Phuc Hoang Chau
<phuc.h.c...@dektech.com.au>
Subject: [PATCH 1/1] imm: fix memory leak reeported by valgrind [#3199]
Fix definitely lost reported by valgrind.
---
src/imm/immd/immd_proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c index
69e23f2..648f8b7 100644
--- a/src/imm/immd/immd_proc.c
+++ b/src/imm/immd/immd_proc.c
@@ -824,6 +824,7 @@ uint32_t immd_process_immnd_down(IMMD_CB *cb,
IMMD_IMMND_INFO_NODE *immnd_info,
}
free(tmpData);
+ ncs_reset_uba(&uba);
[Thuan] use " m_MMGR_FREE_BUFR_LIST(uba.start);" for consistent code.
}
} else {
/* Standby NOT immediately sending D2ND_DISCARD_NODE. But will
--
2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
