Summary: mds: fix receiving old msg under flow control enabled [#3216] Review request for Ticket(s): 3216 Peer Reviewer(s): Minh, Thang Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3216 Base revision: 7a5a4888e753a26765db43ec321235c486072304 Personal repository: git://git.code.sf.net/u/thuantr/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- N/A revision 8ed7ac9a8fa95539d0e7fc785888bca4cc40ed2f Author: thuan.tran <thuan.t...@dektech.com.au> Date: Wed, 26 Aug 2020 17:23:32 +0700 mds: fix receiving old msg under flow control enabled [#3216] - Revert apart of #3151 solution, not decide PortId reset base on fseq=1 but reset rcvwnd when getting Intro msg from known PortId. - Check to skip invalid Nack to avoid sender mistake move to overflow and queue all messages later but receiver don't get any further message to send ChunkAck. - Update tet_receiver() to poll without timeout as sender may take long time for sendto() return due to run out of memory. - Update tet_sender() to slow down sending if amount of message is big and message size is big to avoid kernel kill it as memory usage too much. - Not return error if PortId not found in checking send queue capable to avoid agent crash after fix #3208 if agent enable mds flow control. Complete diffstat: ------------------ src/mds/apitest/mdstipc_api.c | 15 +++++---------- src/mds/mds_tipc_fctrl_intf.cc | 23 ++++++----------------- src/mds/mds_tipc_fctrl_portid.cc | 38 +++++++++++++++++++++++--------------- 3 files changed, 34 insertions(+), 42 deletions(-) Testing Commands: ----------------- N/A Testing, Expected Results: -------------------------- N/A Conditions of Submission: ------------------------- ACK by reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel