ACK. -----Original Message----- From: Thuan Tran <thuan.t...@dektech.com.au> Sent: Monday, December 21, 2020 11:08 AM To: Minh Hon Chau <minh.c...@dektech.com.au>; Thang Duc Nguyen <thang.d.ngu...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran <thuan.t...@dektech.com.au> Subject: [PATCH 2/2] log: do not use trace in signal handler [#3245]
Do not use trace in the signal handler. It can apparently cause the main thread to spin or deadlock. --- src/log/logd/lgs_main.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/log/logd/lgs_main.cc b/src/log/logd/lgs_main.cc index b8ed96ec4..ed21382ef 100644 --- a/src/log/logd/lgs_main.cc +++ b/src/log/logd/lgs_main.cc @@ -150,7 +150,10 @@ static void sigusr1_handler(int sig) { (void)sig; signal(SIGUSR1, SIG_IGN); ncs_sel_obj_ind(&usr1_sel_obj); - TRACE("Got USR1 signal"); + /* Do not use trace in the signal handler + * It can apparently cause the main thread + * to spin or deadlock. See ticket #3245. + */ } /** -- 2.25.1 _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel