Hi Thang,
Thanks for your comment. I will update the comment in v2.
Best Regards,
Thien
-----Original Message-----
From: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>
Sent: Wednesday, February 3, 2021 2:05 PM
To: Thien Minh Huynh <thien.m.hu...@dektech.com.au>; Thanh Nguyen
<thanh.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] clm: clean buffer before decode node address [#3251]
Hi Thien,
Maybe the issue (garbage value) due to using malloc().
You can try with calloc().
B.R/Thang
-----Original Message-----
From: Thien Minh Huynh <thien.m.hu...@dektech.com.au>
Sent: Friday, January 29, 2021 3:23 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thanh Nguyen
<thanh.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
<thien.m.hu...@dektech.com.au>
Subject: [PATCH 1/1] clm: clean buffer before decode node address [#3251]
---
src/clm/common/clmsv_enc_dec.cc | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/clm/common/clmsv_enc_dec.cc b/src/clm/common/clmsv_enc_dec.cc
index 9326ddc9d..82e588cad 100644
--- a/src/clm/common/clmsv_enc_dec.cc
+++ b/src/clm/common/clmsv_enc_dec.cc
@@ -53,6 +53,7 @@ uint32_t clmsv_decodeNodeAddressT(NCS_UBAID *uba,
uint8_t *p8 = nullptr;
uint32_t total_bytes = 0;
+ memset(nodeAddress, '\0', sizeof(SaClmNodeAddressT));
p8 = ncs_dec_flatten_space(uba, local_data, 4);
nodeAddress->family =
static_cast<SaClmNodeAddressFamilyT>(ncs_decode_32bit(&p8));
--
2.25.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
