Summary: osaf: Move the immtool for modifying the IMM model to osaf [#3068]
Review request for Ticket(s): 3068
Peer Reviewer(s): Thanh, Thien
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3068
Base revision: 8ffd9159861d89554615f76588f58b1e37ac0eea
Personal repository: git://git.code.sf.net/u/thangng/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
revision faa45a561ef206946ce18dd3569b9ff482cf955e
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Tue, 23 Mar 2021 08:48:22 +0700
osaf: Move the immtool for modifying the IMM model to osaf [#3068]
The IMM model modifyer tool is move from existing locally in SMF
to osaf tool it becomes a global tool.
Removed Files:
--------------
0001-osaf-Move-the-immtool-for-modifying-the-IMM-model-to.patch----
Complete diffstat:
------------------
opensaf.spec.in | 88 ++++----
src/osaf/Makefile.am | 132 +++++++++++-
.../immtools}/imm_modify_config/README | 0
.../imm_modify_config/add_operation_to_ccb.cc | 20 +-
.../imm_modify_config/add_operation_to_ccb.h | 8 +-
.../immtools}/imm_modify_config/attribute.cc | 12 +-
.../immtools}/imm_modify_config/attribute.h | 17 +-
.../immtools}/imm_modify_config/immccb.cc | 26 +--
.../immtools}/imm_modify_config/immccb.h | 31 ++-
.../immtools}/imm_modify_demo/Makefile | 0
.../smfd => osaf/immtools}/imm_modify_demo/README | 0
.../immtools}/imm_modify_demo/ccbdemo_create.cc | 22 +-
.../immtools}/imm_modify_demo/ccbdemo_delete.cc | 28 +--
.../immtools}/imm_modify_demo/ccbdemo_modify.cc | 72 +------
.../immtools}/imm_modify_demo/common.cc | 2 +-
.../immtools}/imm_modify_demo/common.h | 6 +-
.../immtools}/imm_modify_demo/democlass.xml | 0
.../immtools}/imm_modify_demo/test_ccbhdl.cc | 26 +--
.../immtools}/imm_om_ccapi/common/common.cc | 0
.../immtools}/imm_om_ccapi/common/common.h | 6 +-
.../immtools}/imm_om_ccapi/common/imm_attribute.cc | 0
.../immtools}/imm_om_ccapi/common/imm_attribute.h | 8 +-
.../immtools}/imm_om_ccapi/om_admin_owner_clear.cc | 0
.../immtools}/imm_om_ccapi/om_admin_owner_clear.h | 6 +-
.../imm_om_ccapi/om_admin_owner_handle.cc | 0
.../immtools}/imm_om_ccapi/om_admin_owner_handle.h | 6 +-
.../immtools}/imm_om_ccapi/om_admin_owner_set.cc | 0
.../immtools}/imm_om_ccapi/om_admin_owner_set.h | 6 +-
.../immtools}/imm_om_ccapi/om_ccb_handle.cc | 0
.../immtools}/imm_om_ccapi/om_ccb_handle.h | 6 +-
.../immtools}/imm_om_ccapi/om_ccb_object_create.cc | 0
.../immtools}/imm_om_ccapi/om_ccb_object_create.h | 6 +-
.../immtools}/imm_om_ccapi/om_ccb_object_delete.cc | 0
.../immtools}/imm_om_ccapi/om_ccb_object_delete.h | 6 +-
.../immtools}/imm_om_ccapi/om_ccb_object_modify.cc | 0
.../immtools}/imm_om_ccapi/om_ccb_object_modify.h | 6 +-
.../immtools}/imm_om_ccapi/om_handle.cc | 0
.../immtools}/imm_om_ccapi/om_handle.h | 6 +-
src/smf/Makefile.am | 221 +--------------------
src/smf/smfd/SmfAdminState.cc | 2 +-
src/smf/smfd/SmfExecControlHdl.cc | 2 +-
src/smf/smfd/SmfImmOperation.h | 31 +--
src/smf/smfd/SmfUpgradeStep.cc | 7 +-
src/smf/smfd/SmfUtils.cc | 2 +-
src/smf/smfd/SmfUtils_ObjExist.cc | 3 +-
src/smf/smfd/SmfUtils_ObjExist.h | 2 +-
src/smf/smfd/imm_modify_demo/test_objexist.cc | 127 ------------
47 files changed, 341 insertions(+), 608 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
N/A
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
