Summary: fm: Using log Hexadecimal number for node id instead of Decimal [#2725] Review request for Ticket(s): 2725 Peer Reviewer(s): Thang, Hieu Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2725 Base revision: 0ef3528def6fea13daa1a7a07f34db4994a5e636 Personal repository: git://git.code.sf.net/u/thienhuynh/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 683e9b980a93609dbd9f334a81ec7fbf69a0bb73 Author: thien.m.huynh <thien.m.hu...@dektech.com.au> Date: Fri, 26 Mar 2021 09:18:54 +0700 dtm: Using log Hexadecimal number for node id instead of Decimal [#2725] revision 48e1ff15c013312999bd052078b16a7b12d62558 Author: thien.m.huynh <thien.m.hu...@dektech.com.au> Date: Fri, 26 Mar 2021 09:18:54 +0700 amf: Using log Hexadecimal number for node id instead of Decimal [#2725] revision 85aaf1109f3922763a5bb43f12d33a07389bf393 Author: thien.m.huynh <thien.m.hu...@dektech.com.au> Date: Fri, 26 Mar 2021 09:18:54 +0700 clm: Using log Hexadecimal number for node id instead of Decimal [#2725] revision 7461dd37ff68034ff5edd5d3efaa182e12bfb568 Author: thien.m.huynh <thien.m.hu...@dektech.com.au> Date: Fri, 26 Mar 2021 09:18:54 +0700 fm: Using log Hexadecimal number for node id instead of Decimal [#2725] Complete diffstat: ------------------ src/amf/amfd/ckpt_dec.cc | 2 +- src/amf/amfd/clm.cc | 6 +++--- src/amf/amfd/ndfsm.cc | 6 +++--- src/amf/amfd/ndproc.cc | 8 ++++---- src/amf/amfd/node.cc | 2 +- src/amf/amfd/pg.cc | 4 ++-- src/amf/amfd/role.cc | 4 ++-- src/amf/amfd/sgproc.cc | 4 ++-- src/amf/amfd/siass.cc | 2 +- src/amf/amfd/su.cc | 2 +- src/amf/amfnd/amfnd.cc | 2 +- src/amf/amfnd/cbq.cc | 2 +- src/amf/amfnd/clm.cc | 6 +++--- src/amf/amfnd/comp.cc | 4 ++-- src/amf/amfnd/di.cc | 4 ++-- src/amf/amfnd/imm.cc | 2 +- src/amf/amfnd/proxy.cc | 16 ++++++++-------- src/amf/amfnd/proxydb.cc | 16 ++++++++-------- src/base/sysf_def.c | 4 ++-- src/clm/clmd/clms_evt.cc | 20 ++++++++++---------- src/clm/clmd/clms_imm.cc | 2 +- src/clm/clmd/clms_main.cc | 2 +- src/clm/clmd/clms_mbcsv.cc | 4 ++-- src/clm/clmd/clms_mds.cc | 6 +++--- src/clm/clmd/clms_util.cc | 8 ++++---- src/clm/clmnd/main.cc | 2 +- src/dtm/dtmnd/dtm_inter_svc.cc | 2 +- src/dtm/dtmnd/dtm_intra.cc | 4 ++-- src/dtm/dtmnd/dtm_intra_svc.cc | 22 +++++++++++----------- src/dtm/dtmnd/dtm_node.cc | 6 +++--- src/dtm/dtmnd/dtm_node_db.cc | 12 ++++++------ src/dtm/dtmnd/dtm_node_sockets.cc | 30 +++++++++++++++--------------- src/dtm/dtmnd/dtm_read_config.cc | 2 +- src/fm/fmd/fm_mds.cc | 2 +- 34 files changed, 110 insertions(+), 110 deletions(-) Testing Commands: ----------------- N/A Testing, Expected Results: -------------------------- N/A Conditions of Submission: ------------------------- ACK from reviewer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel