Hi Surbhi,
ACK from me with a minor comment.
The short commit message should describe the changeset in commit.
You can refer :
https://sourceforge.net/p/opensaf/staging/ci/default/tree/tools/devel/review/commit.template
Best Regards,
Thien
-----Original Message-----
From: ztrisur <surbhi.tripa...@dektech.com.au>
Sent: Wednesday, March 24, 2021 5:40 AM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Minh Hon Chau
<minh.c...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel] [PATCH 1/1] imm: missing log level when syslogs security
violation message [#2970]
Passed syslog severity level "LOG_ALERT" with "LOG_AUTH" facility
---
src/imm/immnd/immnd_evt.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/imm/immnd/immnd_evt.c b/src/imm/immnd/immnd_evt.c index
9257529e8..0e801a942 100644
--- a/src/imm/immnd/immnd_evt.c
+++ b/src/imm/immnd/immnd_evt.c
@@ -944,7 +944,7 @@ static uint32_t immnd_evt_proc_imm_init(IMMND_CB *cb,
IMMND_EVT *evt,
getpwuid(sinfo->uid);
if (pwd != NULL)
syslog(
- LOG_AUTH,
+ LOG_ALERT | LOG_AUTH,
"access violation by
%s(uid=%d)",
pwd->pw_name, sinfo->uid);
TRACE_2(
@@ -957,7 +957,7 @@ static uint32_t immnd_evt_proc_imm_init(IMMND_CB *cb,
IMMND_EVT *evt,
getpwuid(sinfo->uid);
if (pwd != NULL)
syslog(
- LOG_AUTH,
+ LOG_ALERT | LOG_AUTH,
"access denied for
%s(uid=%d)",
pwd->pw_name, sinfo->uid);
TRACE_2(
@@ -3734,7 +3734,7 @@ static SaAisErrorT immnd_fevs_local_checks(IMMND_CB *cb,
IMMSV_FEVS *fevsReq,
struct passwd *pwd = getpwuid(sinfo->uid);
if (pwd != NULL) {
syslog(
- LOG_AUTH,
+ LOG_ALERT | LOG_AUTH,
"Modifications to imm service
objects denied for %s(uid=%d)",
pwd->pw_name, sinfo->uid);
}
@@ -3762,7 +3762,7 @@ static SaAisErrorT immnd_fevs_local_checks(IMMND_CB *cb,
IMMSV_FEVS *fevsReq,
getpwuid(sinfo->uid);
if (pwd != NULL)
syslog(
- LOG_AUTH,
+ LOG_ALERT |
LOG_AUTH,
"change of %s
denied for %s(uid=%d)",
attrMod->attrValue
.attrName.buf,
@@ -4149,7 +4149,7 @@ static SaAisErrorT immnd_fevs_local_checks(IMMND_CB *cb,
IMMSV_FEVS *fevsReq,
struct passwd *pwd = getpwuid(sinfo->uid);
if (pwd != NULL) {
syslog(
- LOG_AUTH,
+ LOG_ALERT | LOG_AUTH,
"saImmOmAdminOwnerClear denied for
%s(uid=%d)",
pwd->pw_name, sinfo->uid);
}
--
2.17.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
