Hi Minh, ACK from me with minor comments.
IMMSV_DEFAULT_FEVS_MAX_PENDING has been removed in this patch. I think you should grep "IMMSV_DEFAULT_FEVS_MAX_PENDING" and change it accordingly. > opensaf-code/src/imm/immloadd/imm_loader.cc:2321: has reached > IMMSV_DEFAULT_FEVS_MAX_PENDING. This means that *this* Should add a description of the environment variable "IMMSV_FEVS_MAX_PENDING" to file immnd.conf for ease of use. Best Regards, Thien -----Original Message----- From: Minh Hon Chau <minh.c...@dektech.com.au> Sent: Wednesday, May 12, 2021 7:58 AM To: Thien Minh Huynh <thien.m.hu...@dektech.com.au>; Surbhi Tripathi <surbhi.tripa...@dektech.com.au>; Thang Duc Nguyen <thang.d.ngu...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau <minh.c...@dektech.com.au> Subject: [PATCH 0/2] Review Request for immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260] Summary: immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260] Review request for Ticket(s): 3260 Peer Reviewer(s): Thien, Surbhi, Thang Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-3260 Base revision: 8259816e20e83658f04f0264af19cafa0cdd2755 Personal repository: git://git.code.sf.net/u/minh-chau/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 9e93db5df437d64d674f6b96c0ddba2e72677950 Author: Minh Chau <minh.c...@dektech.com.au> Date: Wed, 12 May 2021 10:52:10 +1000 imma: Correctly use IMMA_SYNCR_TIMEOUT [#3260] revision 52ed58179ea6781c9fb69a6cb057c180cec47dee Author: Minh Chau <minh.c...@dektech.com.au> Date: Wed, 12 May 2021 10:51:53 +1000 immnd: Make IMMSV_FEVS_MAX_PENDING environment variable [#3260] Immnd allows IMMSV_FEVS_MAX_PENDING sourced from enviroment variable, or uses default value (16) otherwise Complete diffstat: ------------------ src/imm/agent/imma_oi_api.cc | 2 +- src/imm/agent/imma_om_api.cc | 2 +- src/imm/agent/imma_proc.cc | 5 +++-- src/imm/common/immsv_api.h | 4 ---- src/imm/immd/immd_cb.h | 1 - src/imm/immnd/ImmModel.cc | 2 +- src/imm/immnd/immnd_cb.h | 1 + src/imm/immnd/immnd_evt.c | 41 +++++++++++++++++++---------------------- src/imm/immnd/immnd_main.c | 15 +++++++++++++++ 9 files changed, 41 insertions(+), 32 deletions(-) Testing Commands: ----------------- *** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES *** Testing, Expected Results: -------------------------- *** PASTE COMMAND OUTPUTS / TEST RESULTS *** Conditions of Submission: ------------------------- *** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC *** Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel