Summary: imm: Introduce a configurable attribute saImmSyncrTimeout [#3268]
Review request for Ticket(s): 3268
Peer Reviewer(s): Minh, Surbhi, Thang
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3268
Base revision: 6d86094bcfbbd0e09e72859a90c9b7d7675a810d
Personal repository: git://git.code.sf.net/u/thienhuynh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 53f4736b360d87126e70e36aa6f7fb23737d3b61
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Mon, 9 Aug 2021 17:13:08 +0700
imm: update README file for a new attribute [#3268]
revision 679a5f1aaaec71d6302f604fbaa5bdc7c3603b54
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Mon, 9 Aug 2021 17:13:08 +0700
imm: add test case of saImmSyncrTimeout attribute [#3268]
Adding 5 new test case into a testsuite 6
revision 575deeb3112c27199f00ca1bd733322c2948a61a
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Mon, 9 Aug 2021 17:12:23 +0700
imm: Introduce a configurable attribute saImmSyncrTimeout [#3268]
In a large cluster size, it is impossible to adjust MDS wait time for all
clients in cluster by change IMMA_SYNC_TIMEOUT environment variable.
Because technique environment variable needs to restart to apply the changed
variable and it is a time-consuming.
This ticket introduce a configurable attribute `saImmSyncrTimeout`
to `SaImmMngt` class, that distribute the new timeout to all IMM clients
and force them to use the new timeout. If user deletes value of attribute
`saImmSyncrTimeout`, it will go back to default value (0). And it is will
keep backward compatible with IMMA_SYNC_TIMEOUT technique.
In default, this feature is disabled.
Correct value of variable environment IMMA_SYNCR_TIMEOUT when set a value
less than 10 will only be interpreted as the value 10.
Added Files:
------------
src/imm/apitest/management/test_saImmConfigSyncrTimeoutImma.c
Complete diffstat:
------------------
src/imm/Makefile.am | 1 +
src/imm/README | 19 ++
src/imm/agent/imma.h | 2 +
src/imm/agent/imma_init.cc | 14 +
src/imm/agent/imma_oi_api.cc | 18 +-
src/imm/agent/imma_om_api.cc | 19 +-
src/imm/agent/imma_proc.cc | 35 +++
.../management/test_saImmConfigSyncrTimeoutImma.c | 296 +++++++++++++++++++++
.../apitest/management/test_saImmOmCcbInitialize.c | 22 ++
src/imm/common/immsv_evt.h | 3 +
src/imm/common/immsv_evt_model.h | 5 +
src/imm/config/immsv_classes.xml | 8 +
src/imm/immnd/ImmAttrValue.cc | 22 ++
src/imm/immnd/ImmAttrValue.h | 2 +
src/imm/immnd/ImmModel.cc | 62 ++++-
src/imm/immnd/ImmModel.h | 4 +-
src/imm/immnd/immnd_cb.h | 1 +
src/imm/immnd/immnd_evt.c | 50 ++++
src/imm/immnd/immnd_init.h | 1 +
19 files changed, 560 insertions(+), 24 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
