Hi Hieu,
ACK with 2 minor comments.
Introduce "the initial clm node status" is intended to replace #1396.
But TC of #1396 doesn't occasionally fail when revert it. I think we should
update test case.
And see comment [thien]
Best Regards,
Thien
-----Original Message-----
From: Hieu Hong Hoang <hieu.h.ho...@dektech.com.au>
Sent: Friday, November 26, 2021 3:30 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thien Minh Huynh
<thien.m.hu...@dektech.com.au>; Minh Hon Chau <minh.c...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
<hieu.h.ho...@dektech.com.au>
Subject: [PATCH 0/3] Review Request for log: shutdown log agent when not in use
[#3291]
Summary: log: Introduce the initial clm node status [#3291] Review request for
Ticket(s): 3291 Peer Reviewer(s): Thang, Minh, Thien Pull request to: *** LIST
THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development
branch: ticket-3291 Base revision: 203ff838c39910902eb16965e964a580b0cffe3b
Personal repository: git://git.code.sf.net/u/hieuhh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision b062a44b596d64f779bc094db350d8a4e0801b6d
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Fri, 26 Nov 2021 15:19:37 +0700
log: increase timeout in logtest [#3291]
Because the log agent have to wait for the clm node status message, increase
timeout in logtest.
revision 27862b018c3522cbf4999dfe8eee9ef65d67a527
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Fri, 26 Nov 2021 11:42:18 +0700
log: Shutdown log agent when not in use [#3291]
When there are no more log client in log agent, unregister mds and shutdown log
agent.
revision 3892a561ab390b068b52ba55f90e59ee5a3f037c
Author: hieu.h.hoang <hieu.h.ho...@dektech.com.au>
Date: Fri, 26 Nov 2021 10:40:41 +0700
log: Introduce the initial clm node status [#3291]
When logd detected loga is up, it will send a callback message to loga.
Loga should wait for the callback message before sending any request.
[Thien] It's better with "Loga should wait for the callback message when loga
was just created"
This callback helps the messages are processed in right order in logd, unorder
message was mentioned in #1396.
Following is the order of processing messages:
1. logd: agent up message
2. loga: initial clm node status message 3. logd: initial client message 4.
logd: final client message 5. logd: agent down message
Complete diffstat:
------------------
src/log/agent/lga_agent.cc | 121 +++++++++++++++++++++++++++++++-
src/log/agent/lga_agent.h | 37 +++++-----
src/log/agent/lga_mds.cc | 82 ++++++++++++++++++++--
src/log/agent/lga_mds.h | 1 +
src/log/agent/lga_util.cc | 75 ++++++++++++++------
src/log/agent/lga_util.h | 1 +
src/log/apitest/tet_saLogStreamOpen_2.c | 4 +-
src/log/common/lgsv_msg.h | 2 +
src/log/logd/lgs_clm.cc | 21 ++++++
src/log/logd/lgs_clm.h | 3 +-
src/log/logd/lgs_evt.cc | 14 ++++
src/log/logd/lgs_mds.cc | 33 ++++++++-
12 files changed, 344 insertions(+), 50 deletions(-)
Testing Commands:
-----------------
*** LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES ***
Testing, Expected Results:
--------------------------
*** PASTE COMMAND OUTPUTS / TEST RESULTS ***
Conditions of Submission:
-------------------------
*** HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC ***
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
