Summary: log: removal of letter 'C'/'R' from msgId in RFC5424 format [#3303]
Review request for Ticket(s): 3303
Peer Reviewer(s): Hieu, Thang, Minh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3303
Base revision: a9e7afa1215407b43c0e993768a003f980e85010
Personal repository: git://git.code.sf.net/u/thienhuynh/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
*** EXPLAIN/COMMENT THE PATCH SERIES HERE ***
revision 04dcdc50d7a6cf96566d0b7571380f164e3c01cd
Author: thien.m.huynh <thien.m.hu...@dektech.com.au>
Date: Wed, 5 Jan 2022 15:53:46 +0700
log: removal of letter 'C'/'R' from msgId in RFC5424 format [#3303]
Remove the 'C'/'R' character at the end of the “mgsid” field.
The purpose of remove to avoid the hashing of log streams
which have name of exactly 32 characters length.
Note: stream name length greater than 32 characters will not be impacted.
Complete diffstat:
------------------
src/log/apitest/tet_cfg_destination.c | 2 +-
src/log/logd/lgs_dest.cc | 17 +++++++----------
src/log/logd/lgs_dest.h | 2 +-
src/log/logd/lgs_imm.cc | 10 ++++------
src/log/logd/lgs_mbcsv.cc | 8 ++++----
src/log/logd/lgs_unixsock_dest.cc | 2 +-
6 files changed, 18 insertions(+), 23 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
ACK from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
