Summary: osaf: support compile gcc/g++ 10 [#3307]
Review request for Ticket(s): 3307
Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE ***
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3307
Base revision: b99fd24c88e4f08799bfcfa9eaa2d585ba426593
Personal repository: git://git.code.sf.net/u/thangng/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision b3c201ea329d1c6370af694728249943cb7f0d95
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Wed, 16 Mar 2022 09:26:59 +0700
osaf: fix memleak in API test [#3307]
Fix some memleak in API test.
revision 430bedc07eb65ab90a1f8894950aae61a9cb6171
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Wed, 16 Mar 2022 09:24:31 +0700
osaf: support compile gcc/g++ 10 [#3307]
Fix error to support compile code with gcc/g++ 10.
Complete diffstat:
------------------
src/ckpt/agent/cpa_cb.h | 2 +-
src/ckpt/apitest/test_cpa.c | 2 +
src/ckpt/apitest/test_cpa_util.c | 13 +++-
src/ckpt/apitest/test_cpsv_conf.h | 2 +-
src/ckpt/ckptd/cpd_amf.c | 1 -
src/ckpt/ckptd/cpd_init.h | 2 +-
src/evt/agent/eda.h | 2 +-
src/evt/apitest/tet_eda.c | 32 +++++++++
src/evt/apitest/tet_eda.h | 80 ++++++++++++++--------
src/evt/apitest/tet_edsv_func.c | 1 +
src/evt/evtd/eds.h | 2 +-
src/evt/evtd/eds_amf.h | 6 +-
src/evt/evtd/eds_cb.h | 2 +-
.../management/test_saImmOmThreadInterference.c | 4 +-
src/imm/immd/immd.h | 2 +-
src/lck/apitest/tet_gld.c | 1 -
src/lck/apitest/tet_glnd.c | 2 -
src/lck/lckd/gld_dl_api.h | 2 +-
src/lck/lcknd/glnd_cb.h | 4 +-
src/log/apitest/logtest.c | 6 ++
src/log/apitest/logtest.h | 6 +-
src/log/logd/lgs_dest.cc | 4 +-
src/mds/apitest/mdstipc.h | 30 ++++----
src/mds/apitest/mdstipc_api.c | 17 +++++
src/mds/mds_core.h | 30 ++++----
src/mds/mds_dt_common.c | 3 +
src/mds/mds_dt_tcp.c | 3 +-
src/mds/mds_dt_tcp.h | 2 +-
src/mds/mds_dt_tipc.c | 2 -
src/mds/mds_main.c | 47 +++++++++++++
src/msg/msgnd/mqnd_db.h | 2 +-
tools/devel/fenced/node_state_hdlr_pl.cc | 1 +
32 files changed, 224 insertions(+), 91 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
Ack from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
