Hi Hieu,
ACK from me.
Best Regards,
Thien
-----Original Message-----
From: Hieu Hong Hoang <hieu.h.ho...@dektech.com.au>
Sent: Friday, March 18, 2022 3:06 PM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Minh Hon Chau
<minh.c...@dektech.com.au>; Thien Minh Huynh <thien.m.hu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Hieu Hong Hoang
<hieu.h.ho...@dektech.com.au>
Subject: [PATCH 1/1] log: The log director always sends the initial message
[#3310]
The log agent 5.22.01 will wait for the initial message but its subpart version
is 1. Therefore the log director doesn't know that it need to send the initial
message.
Solution is the log director always sends the initial message regardless the
version of log agent.
---
src/log/logd/lgs.h | 2 --
src/log/logd/lgs_evt.cc | 6 ++----
src/log/logd/lgs_mds.cc | 14 --------------
3 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/src/log/logd/lgs.h b/src/log/logd/lgs.h index 0be123428..b1d773375
100644
--- a/src/log/logd/lgs.h
+++ b/src/log/logd/lgs.h
@@ -106,7 +106,5 @@ extern uint32_t lgs_mds_change_role(lgs_cb_t *cb); extern
uint32_t lgs_mds_msg_send(lgs_cb_t *cb, lgsv_msg_t *msg, MDS_DEST *dest,
MDS_SYNC_SND_CTXT *mds_ctxt,
MDS_SEND_PRIORITY_TYPE prio); -extern bool
lgs_mds_does_support_init_clm_status(
- lgsv_lgs_mds_info_t *mds_info);
#endif // LOG_LOGD_LGS_H_
diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc index
5052a542d..6b186cdc3 100644
--- a/src/log/logd/lgs_evt.cc
+++ b/src/log/logd/lgs_evt.cc
@@ -426,10 +426,8 @@ static uint32_t proc_lga_updn_mds_msg(lgsv_lgs_evt_t *evt)
{
} else {
clusterChange = SA_CLM_NODE_LEFT;
}
- if (lgs_mds_does_support_init_clm_status(&evt->info.mds_info)) {
- /* Send clm status to log agent */
- lgs_send_clm_node_status(clusterChange, evt->fr_dest);
- }
+ /* Send clm status to log agent */
+ lgs_send_clm_node_status(clusterChange, evt->fr_dest);
}
break;
diff --git a/src/log/logd/lgs_mds.cc b/src/log/logd/lgs_mds.cc index
e65f31431..f6175ab04 100644
--- a/src/log/logd/lgs_mds.cc
+++ b/src/log/logd/lgs_mds.cc
@@ -1591,17 +1591,3 @@ uint32_t lgs_mds_msg_send(lgs_cb_t *cb, lgsv_msg_t *msg,
MDS_DEST *dest,
}
return rc;
}
-
-/****************************************************************************
- * Name : lgs_mds_does_support_init_clm_status
- *
- * Description : Check if the log agent supports the init clm status or not
- *
- * Arguments : mds_info - ptr to the mds info
- *
- * Return Values : true/false
- *****************************************************************************/
-bool lgs_mds_does_support_init_clm_status(lgsv_lgs_mds_info_t *mds_info) {
- return mds_info->i_rem_svc_pvt_ver >=
- LGS_WRT_LGA_INIT_CLM_STATE_SUBPART_VERSION;
-}
--
2.25.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
