Summary: build: fix HIGH severity in codechecker [#3327]
Review request for Ticket(s): 3327
Peer Reviewer(s): *** LIST THE TECH REVIEWER(S) / MAINTAINER(S) HERE ***
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-3327
Base revision: bb193b9154084ee57164e3783f7499fbc1443a9a
Personal repository: git://git.code.sf.net/u/thangng/review
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services y
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
NOTE: Patch(es) contain lines longer than 80 characers
Comments (indicate scope for each "y" above):
---------------------------------------------
revision 41a0e8e3525f7635f928ffb6740bb378ee1c0fbd
Author: thang.d.nguyen <thang.d.ngu...@dektech.com.au>
Date: Tue, 7 Mar 2023 11:29:47 +0700
build: fix HIGH severity in codechecker [#3327]
Fix HIGH severity in codechecker report.
Complete diffstat:
------------------
src/amf/amfd/ndmsg.cc | 4 ++--
src/amf/amfd/ndproc.cc | 4 ++--
src/amf/amfd/timer.cc | 4 ++--
src/amf/amfnd/amfnd.cc | 4 ++--
src/amf/amfnd/mds.cc | 15 ++++++++-------
src/amf/amfnd/su.cc | 2 +-
src/amf/amfnd/tmr.cc | 4 ++--
src/clm/agent/clma_util.cc | 5 +++++
src/clm/apitest/tet_saClmInitialize.cc | 6 ++++--
src/imm/immloadd/imm_pbe_load.cc | 16 ++++++++++++++--
src/imm/immpbed/immpbe_daemon.cc | 18 ++++++++++++++++--
src/imm/tools/imm_admin.c | 8 +++++++-
src/log/apitest/saflogtest.c | 2 +-
src/log/apitest/tet_saLogStreamOpen_2.c | 2 +-
src/log/logd/lgs_clm.cc | 2 ++
src/log/logd/lgs_stream.cc | 2 ++
src/nid/nodeinit.cc | 8 ++++++--
src/ntf/apitest/tet_longDnObject_notification.cc | 2 +-
src/ntf/apitest/tet_ntf_common.cc | 2 +-
src/ntf/apitest/tet_saNtfNotificationReadInitialize.cc | 2 +-
src/ntf/apitest/tet_saNtfNotificationSend.cc | 4 ++--
src/ntf/apitest/tet_scOutage_reinitializeHandle.cc | 5 +++--
src/ntf/ntfimcnd/ntfimcn_imm.c | 4 ++--
src/ntf/tools/ntfsend.c | 5 +++++
src/osaf/immutil/immutil.c | 7 ++++++-
src/smf/smfd/SmfUpgradeProcedure.cc | 18 +++++++++---------
26 files changed, 107 insertions(+), 48 deletions(-)
Testing Commands:
-----------------
N/A
Testing, Expected Results:
--------------------------
N/A
Conditions of Submission:
-------------------------
Ack from reviewer
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
