Hi Dat,
See my comments.
Best Regards,
Thien
-----Original Message-----
From: Dat Tran Quoc Phan <dat.tq.p...@dektech.com.au>
Sent: Tuesday, March 28, 2023 10:44 AM
To: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>; Thien Minh Huynh
<thien.m.hu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Dat Tran Quoc Phan
<dat.tq.p...@dektech.com.au>
Subject: [PATCH 1/1] rde: fix errors reported by Valgrind [#3333]
Fix memleak detected by Valgrind when receive rde message.
Also fix the uninitialized value(s).
---
src/rde/rded/rde_amf.cc | 1 +
src/rde/rded/rde_mds.cc | 2 ++
2 files changed, 3 insertions(+)
diff --git a/src/rde/rded/rde_amf.cc b/src/rde/rded/rde_amf.cc index
5a80bc418..a732f5a7b 100644
--- a/src/rde/rded/rde_amf.cc
+++ b/src/rde/rded/rde_amf.cc
@@ -151,6 +151,7 @@ uint32_t rde_amf_init(RDE_AMF_CB *rde_amf_cb) {
NCSCC_RC_SUCCESS)
return NCSCC_RC_FAILURE;
+ memset(&amfCallbacks,0,sizeof(amfCallbacks));
[Thien]: there should be a gap after each comma.
amfCallbacks.saAmfHealthcheckCallback = rde_saf_health_chk_callback;
amfCallbacks.saAmfCSISetCallback = rde_saf_CSI_set_callback;
amfCallbacks.saAmfCSIRemoveCallback = rde_saf_CSI_rem_callback; diff --git
a/src/rde/rded/rde_mds.cc b/src/rde/rded/rde_mds.cc index 4591d1996..1ed17ae00
100644
--- a/src/rde/rded/rde_mds.cc
+++ b/src/rde/rded/rde_mds.cc
@@ -106,6 +106,8 @@ static uint32_t msg_decode(MDS_CALLBACK_DEC_INFO *dec_info)
{
static_cast<uint64_t>(ncs_decode_64bit(&data));
ncs_dec_skip_space(uba, sizeof(uint64_t));
}
+ /* uba not used after */
+ ncs_reset_uba(uba);
[Thien]:
ncs_dec_skip_space(uba, sizeof(uint64_t));
A better option would be to move the function outside of the
"msg->info.peer_info.ha_role == PCS_RDA_UNDEFINED" scoop condition.
break;
default:
--
2.17.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
