Hi Thang,
I see my comment inline [Thien].
Best Regards,
Thien
-----Original Message-----
From: Thang Duc Nguyen <thang.d.ngu...@dektech.com.au>
Sent: Monday, May 6, 2024 7:48 PM
To: Thien Minh Huynh <thien.m.hu...@dektech.com.au>; Dat Tran Quoc Phan
<dat.tq.p...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
<thang.d.ngu...@dektech.com.au>
Subject: [PATCH 1/1] osaf: supports build with gcc/g++ 13 [#3352]
Fix some minor errors while build/compile source code with gcc/g++ 13.
---
src/imm/immnd/ImmModel.h | 1 +
src/osaf/consensus/consensus_env.h | 1 +
src/smf/smfnd/smfnd_amf.c | 2 +-
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/imm/immnd/ImmModel.h b/src/imm/immnd/ImmModel.h index
02e2178e5..3c5860cb5 100644
--- a/src/imm/immnd/ImmModel.h
+++ b/src/imm/immnd/ImmModel.h
@@ -21,6 +21,7 @@
#include <saImmOm.h>
#include <cstdarg>
+#include <cstdint>
#include <sys/types.h>
#include <string>
#include <vector>
diff --git a/src/osaf/consensus/consensus_env.h
b/src/osaf/consensus/consensus_env.h
index df4f93a7a..1a60b2d82 100644
--- a/src/osaf/consensus/consensus_env.h
+++ b/src/osaf/consensus/consensus_env.h
@@ -16,6 +16,7 @@
#define OSAF_CONSENSUS_CONSENSUS_ENV_H_
#include <string>
+#include <cstdint>
#include "base/mutex.h"
typedef struct _ConsensusCfg {
diff --git a/src/smf/smfnd/smfnd_amf.c b/src/smf/smfnd/smfnd_amf.c index
99a373922..787d60699 100644
--- a/src/smf/smfnd/smfnd_amf.c
+++ b/src/smf/smfnd/smfnd_amf.c
@@ -223,7 +223,7 @@ static SaAisErrorT amf_healthcheck_start(smfnd_cb_t *cb)
SA_AIS_ERR_* - failure
**************************************************************************/
-SaAisErrorT smfnd_amf_init(smfnd_cb_t *cb)
+uint32_t smfnd_amf_init(smfnd_cb_t *cb)
[Thien]: Why did you change from SaAisErrorT -> uint32_t during that return
data declaration is SaAisErrorT.
SaAisErrorT result;
The header file change from uint32_t -> SaAisErrorT will match the data
returned.
{
SaAmfCallbacksT amfCallbacks;
SaVersionT amf_version;
--
2.25.1
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
