- **status**: accepted --> review
- **Comment**:
sending [PATCH 0 of 7] Review Request for AMF SU refactoring #713 ...
sending [PATCH 1 of 7] amfd: add and use SU assignment count methods [#713] ...
sending [PATCH 2 of 7] amfd: add and use set_su_failover [#713] ...
sending [PATCH 3 of 7] amfd: add and use SU method set_term_state [#713] ...
sending [PATCH 4 of 7] amfd: add SU constr/destr [#713] ...
sending [PATCH 5 of 7] amfd: add and use set_su_switch [#713] ...
sending [PATCH 6 of 7] amfd: add and use SU get_node_ptr [#713] ...
sending [PATCH 7 of 7] amfd: add and use SU is_in_service [#713] ...
---
** [tickets:#713] AMF refactoring for 4.5**
**Status:** review
**Milestone:** 4.5.FC
**Created:** Fri Jan 10, 2014 07:05 AM UTC by Hans Feldt
**Last Updated:** Tue Apr 29, 2014 08:55 PM UTC
**Owner:** Hans Feldt
This is a 4.5 ticket for continued code re-factoring of the AMF service for
4.5. The work started with #94 in 4.4.
So far no really no C++ features has been used. Files has been renamed so that
the C++ compiler is used and new/delete is used instead of malloc/free (where
appropriate).
In this ticket it is time to make use of C++ features to get a more
maintainable and understandable code base. We should aim for many small changes
instead of few big ones.
An ordered list of things to work on:
1. Use bool which is a native type in C++ (and remove SaBoolT)
2. Reduce number of casts in the code (introduced because of C++ files)
2. Use stl::maps (instead of patricia trees)
3. Use stl::vector/list (instead of legacy/home made lists)
Other yet non prioritized items:
- Remove use of EDU and do direct encode/decode
- Clean run of google's cpplint on the code base
- Convert model derived C structs to classes and change functions into methods
- Change macros to (inline) methods
- Change bit fields (flags) to boolean attributes (see
https://sourceforge.net/p/opensaf/tickets/717/#d4b2)
- Use references instead of pointers
- ...
Non C++ related changes:
- split up long functions into smaller ones doing one things and not many
- use pmccabe complexity analysis to aid refactoring
- set a goal for pmccabe complexity
- use const as much as possible
- ...
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
