- **status**: review --> fixed
- **Comment**:

changeset:   8073:b7ba90304dce
tag:         tip
parent:      8069:b30d5e33e50c
user:        Neelakanta Reddy
date:        Thu Sep 15 11:45:40 2016 +0530
summary:     imm: return the correct error code for ERR_LIBRARY in 
saImmOiAugmentCcbInitialize [#1816]

changeset:   8072:c472ada0394c
branch:      opensaf-5.1.x
parent:      8068:87a09d9164d3
user:        Neelakanta Reddy
date:        Thu Sep 15 11:45:40 2016 +0530
summary:     imm: return the correct error code for ERR_LIBRARY in 
saImmOiAugmentCcbInitialize [#1816]

changeset:   8071:ef0846e8e5c9
branch:      opensaf-5.0.x
parent:      8067:efeaffca9483
user:        Neelakanta Reddy
date:        Thu Sep 15 11:45:40 2016 +0530
summary:     imm: return the correct error code for ERR_LIBRARY in 
saImmOiAugmentCcbInitialize [#1816]

changeset:   8070:af5ecf3d1a72
branch:      opensaf-4.7.x
parent:      8066:afddc603adcb
user:        Neelakanta Reddy
date:        Thu Sep 15 11:45:40 2016 +0530
summary:     imm: return the correct error code for ERR_LIBRARY in 
saImmOiAugmentCcbInitialize [#1816]




---

** [tickets:#1816] IMM: saImmOiAugmentCcbInitialize returned ERR_TRY_AGAIN when 
ERR_LIBRARY was expected**

**Status:** fixed
**Milestone:** 4.7.2
**Created:** Mon May 09, 2016 07:27 AM UTC by Chani Srivastava
**Last Updated:** Tue Sep 13, 2016 11:47 AM UTC
**Owner:** Neelakanta Reddy


This was found as part of validating ticket #1808

Code snippet: imma_oi_api.c:3749

~~~
 if(immsv_om_handle_initialize) {/*This is always the first immsv_om_ call */
                        rc = immsv_om_handle_initialize(&privateOmHandle, 
&version);
                } else {
                        TRACE("ERR_LIBRARY: Error in library linkage. 
libSaImmOm.so is not linked");
                        rc = SA_AIS_ERR_LIBRARY;
                }

                if(rc != SA_AIS_OK) {
                        TRACE("ERR_TRY_AGAIN: failed to obtain internal om 
handle rc:%u", rc);
                        rc = SA_AIS_ERR_TRY_AGAIN;
                        goto lock_fail; /* We are not locked and nothing to 
de-allocate.  */
                }
~~~

When rc is set to SA_AIS_ERR_LIBRARY, there is no goto and hence next if 
condition is executed which sets rc SA_AIS_ERR_TRY_AGAIN



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to