Hi Nagu,
I guess I can summary it as below:
1. During genearting of the merged campaign, the tmpDU will be generated base
on the original rolling procedure or singleStep/ForModify since they're
symmetric.
2. AU will be generated from tmpDU.
3. Orignal singleStep/ForAddRemove AU/DU then will be appended into the
generated AU/DU. The reason of this is because it's not symmetry hence
everything from the original must be include.
Since we unconditionally include the singleStep/ForAddRemove AU/DU into the
result AU/DU, there are some changes that there will be some duplicated
entities in the result AU/DU and cause the campaign failed to be executed.
The solution came up here is that we should remove the duplicated entities
inside the original singleStep/ForAddRemove before appending them into the
result proc.
By this we not only fix the campaign execution failed issue but also still
align with the SMF PR. Since all entities in the original
singleStep/ForAddRemove are added into the result one.
I think Neel is OK with the patch but we're still waiting for more comments
from Lennart/Rafael.
I hope that I'm a bit clearer.
/Tai
---
** [tickets:#2209] SMF: ONE-STEP upgrade failed due to duplicated entities in
AU/DU**
**Status:** unassigned
**Milestone:** 5.1.1
**Created:** Mon Nov 28, 2016 07:01 AM UTC by Tai Dinh
**Last Updated:** Wed Nov 30, 2016 07:01 AM UTC
**Owner:** nobody
**Attachments:**
-
[one_step_upgrade_fix.patch](https://sourceforge.net/p/opensaf/tickets/2209/attachment/one_step_upgrade_fix.patch)
(3.0 kB; application/octet-stream)
Execution of ONE-STEP upgrade will fail if the original campaign contains
forAddRemove Single Step procedure that have duplicated entities with another
procedure.
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO STEP: Lock deactivation units
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO createNodeGroup: saImmOmCcbApply()
Fail 'SA_AIS_ERR_FAILED_OPERATION (21)'
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO changeNodeGroupAdminState:
createNodeGroup() Fail SA_AIS_ERR_FAILED_OPERATION (21)
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO lock: changeNodeGroupAdminState()
Fail SA_AIS_ERR_FAILED_OPERATION (21)
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: ER Failed to Lock deactivation units in
step=safSmfStep=0001
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: ER Step execution failed, Try undoing
the step
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO SmfStepStateUndoing::execute start
undoing step.
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: ER Rollback of cluster reboot activate
step is not implemented
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: ER Step undoing failed
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO Step safSmfStep=0001 in procedure
safSmfProc=SmfSSMergedProc failed, step result 5
Nov 26 18:30:02 SC-2-2 osafsmfd[4929]: NO CAMP: Procedure
safSmfProc=SmfSSMergedProc returned FAILED
Nov 26 18:30:11 SC-2-2 osafsmfd[4929]: ER Failed to rollback campaign, wrong
state 10
The reason of this is because during calculating/optimizing the AU/DU of the
merged procedure, the original AU/DU of that single step procedure is always
appended into the result procedure without checking for duplicated entities.
This need to be fixed by removing any duplicated entities that is already
presented in the tmpDU before optimization.
See attachment for a proposed fix.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
