- Description has changed:

Diff:

~~~~

--- old
+++ new
@@ -1,67 +1,74 @@
-2017-02-24 10:18:04 INFO: *** List of cppcheck errors added by patch ***
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::amfSelectionObject' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::amf_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::amf_invocation_id' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::async_upd_cnt' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::ckpt_state' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::clmSelectionObject' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::clm_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::clm_init_sel_obj' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::comp_name' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::edu_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::fully_initialized' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::ha_state' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::immOiHandle' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::immSelectionObject' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::is_quiesced_set' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::last_client_id' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::lga_down_list_head' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::lga_down_list_tail' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::log_version' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mbcsv_ckpt_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mbcsv_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mbcsv_peer_version' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mbcsv_sel_obj' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mds_hdl' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::mds_role' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::nid_started' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::scAbsenceAllowed' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_cb.h:106]: (warning) Member 
variable 'lgs_cb::vaddr' is not initialized in the constructor.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_clm.cc:137]: (style) The 
scope of the variable 'clm_node' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_clm.cc:213]: (style) The 
scope of the variable 'rec' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_clm.cc:220]: (performance) 
Prefer prefix ++/-- operators for non-primitive types.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:1493]: (style) 
Condition '0' is always false
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:163]: (error) 
Mismatching allocation and deallocation: client
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:168]: (error) 
Mismatching allocation and deallocation: client
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:344]: (performance) 
Prefer prefix ++/-- operators for non-primitive types.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:416]: (style) The 
scope of the variable 'ckpt_ptr' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:417]: (style) The 
scope of the variable 'async_rc' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:532]: (style) The 
scope of the variable 'temp_lga_down_rec' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:553]: (style) The 
scope of the variable 'stream' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:671]: (style) The 
scope of the variable 'ckpt_ptr' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_evt.cc:672]: (style) The 
scope of the variable 'header_ptr' can be reduced.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:1112]: (style) 
Condition '0' is always false
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:1148] -> 
[src/log/logd/lgs_mbcsv.cc:1125]: (style) Variable 'rc' is reassigned a value 
before the old one has been used.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:1671]: (style) 
Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 
'setitimer' instead.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:1875]: (style) 
Checking if unsigned variable 'clientId' is less than zero.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:711]: 
(performance) Prefer prefix ++/-- operators for non-primitive types.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:767]: 
(performance) Function parameter 'edu_hdl' should be passed by reference.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:941] -> 
[src/log/logd/lgs_mbcsv.cc:938]: (style) Variable 'rc' is reassigned a value 
before the old one has been used.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_mbcsv.cc:985]: (style) 
Obsolescent function 'usleep' called. It is recommended to use 'nanosleep' or 
'setitimer' instead.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_util.cc:363]: (performance) 
Prefer prefix ++/-- operators for non-primitive types.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_util.cc:521]: (style) The 
function 'lgs_check_path_exists_h' is never used.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_util.cc:566]: (portability) 
Non reentrant function 'getgrnam' called. For threadsafe applications it is 
recommended to use the reentrant replacement function 'getgrnam_r'.
-2017-02-24 10:18:04 INFO: ***    [src/log/logd/lgs_util.cc:912]: (performance) 
Prefer prefix ++/-- operators for non-primitive types.
-
-----------
-
-'2017-02-23 13:44:28,233 INFO - *** List of cppcheck errors added by patch ***'
-'2017-02-23 13:44:28,233 INFO - ***    [src/log/logd/lgs_filehdl.cc:577]: 
(style) Variable 'len' is assigned a value that is never used.'
-'2017-02-23 13:44:28,233 INFO - ***    [src/log/logd/lgs_stream.cc:1337]: 
(style) Unsigned variable 'id' can't be negative so it is unnecessary to test 
it.'
-'2017-02-23 13:44:28,234 INFO - ***    [src/log/logd/lgs_stream.cc:1350]: 
(style) The scope of the variable 'tmp' can be reduced.'
-'2017-02-23 13:44:28,234 INFO - ***    [src/log/logd/lgs_stream.cc:1447]: 
(style) The function 'log_stream_id_print' is never used.'
-'2017-02-23 13:44:28,234 INFO - ***    [src/log/logd/lgs_stream.cc:408]: 
(style) The function 'log_free_stream_resources' is never used.'
-'2017-02-23 13:44:28,234 INFO - ***    [src/log/logd/lgs_stream.cc:416]: 
(warning) Assignment of function parameter has no effect outside the function. 
Did you forget dereferencing it?'
-'2017-02-23 13:44:28,235 INFO - ***    [src/log/logd/lgs_stream.cc:533]: 
(portability) Non reentrant function 'strtok' called. For threadsafe 
applications it is recommended to use the reentrant replacement function 
'strtok_r'.'
-'2017-02-23 13:44:28,235 INFO - ***    [src/log/logd/lgs_stream.cc:852]: 
(style) Obsolescent function 'usleep' called. It is recommended to use 
'nanosleep' or 'setitimer' instead.'
-'2017-02-23 13:44:28,235 INFO - ***    [src/log/logd/lgs_stream.cc:869]: 
(style) Obsolescent function 'usleep' called. It is recommended to use 
'nanosleep' or 'setitimer' instead.' 
+[staging/src/log/logd/lgs_config.h:90]: (performance) Function parameter 
param_name should be passed by reference.
+[staging/src/log/logd/lgs_config.h:230]: (performance) Function parameter 
attribute_name should be passed by reference.
+[staging/src/log/logd/lgs_config.h:231]: (performance) Function parameter 
value_list should be passed by reference.
+[staging/src/log/logd/lgs_config.h:238]: (performance) Function parameter 
attribute_name should be passed by reference.
+[staging/src/log/logd/lgs_config.h:239]: (performance) Function parameter 
value_list should be passed by reference.
+[staging/src/log/logd/lgs_clm.cc:137]: (style) The scope of the variable 
clm_node can be reduced.
+[staging/src/log/logd/lgs_clm.cc:220]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
+[staging/src/log/logd/lgs_config.cc:401] -> 
[staging/src/log/logd/lgs_config.cc:498]: (warning) Either the condition 
allocmem_ptr!=NULL is redundant or there is possible null pointer dereference: 
param_ptr.
+[staging/src/log/logd/lgs_config.cc:410] -> 
[staging/src/log/logd/lgs_config.cc:498]: (warning) Either the condition 
allocmem_ptr!=NULL is redundant or there is possible null pointer dereference: 
param_ptr.
+[staging/src/log/logd/lgs_config.cc:184] -> 
[staging/src/log/logd/lgs_config.cc:190]: (style) Variable cfg_param_str is 
reassigned a value before the old one has been used.
+[staging/src/log/logd/lgs_config.cc:183]: (style) The scope of the variable 
prev_size can be reduced.
+[staging/src/log/logd/lgs_config.cc:727]: (style) The scope of the variable 
nl_cnt can be reduced.
+[staging/src/log/logd/lgs_config.cc:995]: (style) The scope of the variable 
value_string can be reduced.
+[staging/src/log/logd/lgs_config.cc:1034]: (style) The scope of the variable n 
can be reduced.
+[staging/src/log/logd/lgs_config.cc:142]: (warning) Member variable 
_lgs_conf_t::chkp_file_close_time is not initialized in the constructor.
+[staging/src/log/logd/lgs_config.cc:293]: (performance) Function parameter 
attribute_name should be passed by reference.
+[staging/src/log/logd/lgs_config.cc:294]: (performance) Function parameter 
value_list should be passed by reference.
+[staging/src/log/logd/lgs_config.cc:324]: (performance) Function parameter 
attribute_name should be passed by reference.
+[staging/src/log/logd/lgs_config.cc:325]: (performance) Function parameter 
value_list should be passed by reference.
+[staging/src/log/logd/lgs_evt.cc:531] -> 
[staging/src/log/logd/lgs_evt.cc:536]: (style) Variable lga_down_rec is 
reassigned a value before the old one has been used.
+[staging/src/log/logd/lgs_evt.cc:416]: (style) The scope of the variable 
ckpt_ptr can be reduced.
+[staging/src/log/logd/lgs_evt.cc:553]: (style) The scope of the variable 
stream can be reduced.
+[staging/src/log/logd/lgs_evt.cc:163]: (error) Mismatching allocation and 
deallocation: client
+[staging/src/log/logd/lgs_evt.cc:168]: (error) Mismatching allocation and 
deallocation: client
+[staging/src/log/logd/lgs_evt.cc:344]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
+[staging/src/log/logd/lgs_filehdl.cc:542]: (style) Variable len is assigned a 
value that is never used.
+[staging/src/log/logd/lgs_fmt.cc:560]: (style) The scope of the variable no_ch 
can be reduced.
+[staging/src/log/logd/lgs_imm.cc:3478] -> 
[staging/src/log/logd/lgs_imm.cc:3479]: (warning) Either the condition 
attribute!=NULL is redundant or there is possible null pointer dereference: 
attribute.
+[staging/src/log/logd/lgs_imm.cc:963]: (style) The scope of the variable i can 
be reduced.
+[staging/src/log/logd/lgs_imm.cc:1885]: (style) The scope of the variable 
current_time can be reduced.
+[staging/src/log/logd/lgs_imm.cc:1924]: (style) The scope of the variable 
stream can be reduced.
+[staging/src/log/logd/lgs_imm.cc:3264]: (style) The scope of the variable 
name_str can be reduced.
+[staging/src/log/logd/lgs_imm.cc:3474]: (style) The scope of the variable 
value can be reduced.
+[staging/src/log/logd/lgs_imm_gcfg.cc:857] -> 
[staging/src/log/logd/lgs_imm_gcfg.cc:859]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/logd/lgs_imm_gcfg.cc:532]: (style) The scope of the variable 
name_len can be reduced.
+[staging/src/log/logd/lgs_imm_gcfg.cc:940]: (style) The scope of the variable 
rc can be reduced.
+[staging/src/log/logd/lgs_main.cc:319]: (style) Suspicious condition 
(assignment + comparison); Clarify expression with parentheses.
+[staging/src/log/logd/lgs_mbcsv.cc:214]: (style) Suspicious condition 
(assignment + comparison); Clarify expression with parentheses.
+[staging/src/log/logd/lgs_mbcsv.cc:541] -> 
[staging/src/log/logd/lgs_mbcsv.cc:551]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/logd/lgs_mbcsv.cc:695] -> 
[staging/src/log/logd/lgs_mbcsv.cc:702]: (style) Variable pheader is reassigned 
a value before the old one has been used.
+[staging/src/log/logd/lgs_mbcsv.cc:938] -> 
[staging/src/log/logd/lgs_mbcsv.cc:941]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/logd/lgs_mbcsv.cc:1125] -> 
[staging/src/log/logd/lgs_mbcsv.cc:1148]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/logd/lgs_mbcsv.cc:1875]: (style) Checking if unsigned 
variable clientId is less than zero.
+[staging/src/log/logd/lgs_mbcsv.cc:711]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
+[staging/src/log/logd/lgs_mds.cc:1003] -> 
[staging/src/log/logd/lgs_mds.cc:1009]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/logd/lgs_stream.cc:416]: (warning) Assignment of function 
parameter has no effect outside the function. Did you forget dereferencing it?
+[staging/src/log/logd/lgs_stream.cc:665] -> 
[staging/src/log/logd/lgs_stream.cc:669]: (style) Variable stream is reassigned 
a value before the old one has been used.
+[staging/src/log/logd/lgs_stream.cc:1337]: (style) Unsigned variable id cant 
be negative so it is unnecessary to test it.
+[staging/src/log/logd/lgs_util.cc:363]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
+[staging/src/log/logd/lgs_util.cc:912]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
+[staging/src/log/logd/lgs_config.cc:1854]: (style) The function 
lgs_cfg_read_trace is never used.
+[staging/src/log/logd/lgs_util.cc:521]: (style) The function 
lgs_check_path_exists_h is never used.
+[staging/src/log/logd/lgs_imm.cc:3234]: (style) The function 
lgs_delete_one_stream_object is never used.
+[staging/src/log/logd/lgs_stream.cc:408]: (style) The function 
log_free_stream_resources is never used.
+[staging/src/log/logd/lgs_stream.cc:1447]: (style) The function 
log_stream_id_print is never used.
+[staging/src/log/logd/lgs_config.cc:1513]: (style) The function 
update_multival_rattr is never used.
+(information) Cppcheck cannot find all the include files (use --check-config 
for details)
+[staging/src/log/agent/lga_api.c:1104] -> 
[staging/src/log/agent/lga_api.c:1106]: (style) Variable logSvcUsrChars is 
reassigned a value before the old one has been used.
+[staging/src/log/agent/lga_mds.c:1408] -> 
[staging/src/log/agent/lga_mds.c:1428]: (style) Variable rc is reassigned a 
value before the old one has been used.
+[staging/src/log/agent/lga_mds.c:1219]: (style) The scope of the variable rc 
can be reduced.
+[staging/src/log/agent/lga_state.c:412] -> 
[staging/src/log/agent/lga_state.c:421]: (style) Variable ncs_rc is reassigned 
a value before the old one has been used.
+[staging/src/log/agent/lga_util.c:312] -> 
[staging/src/log/agent/lga_util.c:317]: (style) Variable client_hdl is 
reassigned a value before the old one has been used.
+[staging/src/log/agent/lga_util.c:416]: (style) The function 
lga_force_shutdown is never used.
+[staging/src/log/agent/lga_util.c:890]: (style) The function 
logtrace_init_constructor is never used.
+[staging/src/log/agent/lga_api.c:419]: (style) The function saLogDispatch is 
never used.
+[staging/src/log/agent/lga_api.c:538]: (style) The function saLogFinalize is 
never used.
+[staging/src/log/agent/lga_api.c:165]: (style) The function saLogInitialize is 
never used.
+[staging/src/log/agent/lga_api.c:1529]: (style) The function saLogLimitGet is 
never used.
+[staging/src/log/agent/lga_api.c:351]: (style) The function 
saLogSelectionObjectGet is never used.
+[staging/src/log/agent/lga_api.c:1373]: (style) The function saLogStreamClose 
is never used.
+[staging/src/log/agent/lga_api.c:1026]: (style) The function 
saLogStreamOpenAsync_2 is never used.
+[staging/src/log/agent/lga_api.c:798]: (style) The function saLogStreamOpen_2 
is never used.
+[staging/src/log/agent/lga_api.c:1164]: (style) The function saLogWriteLog is 
never used.
+[staging/src/log/agent/lga_api.c:1180]: (style) The function 
saLogWriteLogAsync is never used.

~~~~

- **status**: assigned --> review



---

** [tickets:#2326] log : fix all cpp check issues **

**Status:** review
**Milestone:** next
**Created:** Mon Feb 27, 2017 03:40 AM UTC by A V Mahesh (AVM)
**Last Updated:** Mon Feb 27, 2017 03:40 AM UTC
**Owner:** A V Mahesh (AVM)


[staging/src/log/logd/lgs_config.h:90]: (performance) Function parameter 
param_name should be passed by reference.
[staging/src/log/logd/lgs_config.h:230]: (performance) Function parameter 
attribute_name should be passed by reference.
[staging/src/log/logd/lgs_config.h:231]: (performance) Function parameter 
value_list should be passed by reference.
[staging/src/log/logd/lgs_config.h:238]: (performance) Function parameter 
attribute_name should be passed by reference.
[staging/src/log/logd/lgs_config.h:239]: (performance) Function parameter 
value_list should be passed by reference.
[staging/src/log/logd/lgs_clm.cc:137]: (style) The scope of the variable 
clm_node can be reduced.
[staging/src/log/logd/lgs_clm.cc:220]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
[staging/src/log/logd/lgs_config.cc:401] -> 
[staging/src/log/logd/lgs_config.cc:498]: (warning) Either the condition 
allocmem_ptr!=NULL is redundant or there is possible null pointer dereference: 
param_ptr.
[staging/src/log/logd/lgs_config.cc:410] -> 
[staging/src/log/logd/lgs_config.cc:498]: (warning) Either the condition 
allocmem_ptr!=NULL is redundant or there is possible null pointer dereference: 
param_ptr.
[staging/src/log/logd/lgs_config.cc:184] -> 
[staging/src/log/logd/lgs_config.cc:190]: (style) Variable cfg_param_str is 
reassigned a value before the old one has been used.
[staging/src/log/logd/lgs_config.cc:183]: (style) The scope of the variable 
prev_size can be reduced.
[staging/src/log/logd/lgs_config.cc:727]: (style) The scope of the variable 
nl_cnt can be reduced.
[staging/src/log/logd/lgs_config.cc:995]: (style) The scope of the variable 
value_string can be reduced.
[staging/src/log/logd/lgs_config.cc:1034]: (style) The scope of the variable n 
can be reduced.
[staging/src/log/logd/lgs_config.cc:142]: (warning) Member variable 
_lgs_conf_t::chkp_file_close_time is not initialized in the constructor.
[staging/src/log/logd/lgs_config.cc:293]: (performance) Function parameter 
attribute_name should be passed by reference.
[staging/src/log/logd/lgs_config.cc:294]: (performance) Function parameter 
value_list should be passed by reference.
[staging/src/log/logd/lgs_config.cc:324]: (performance) Function parameter 
attribute_name should be passed by reference.
[staging/src/log/logd/lgs_config.cc:325]: (performance) Function parameter 
value_list should be passed by reference.
[staging/src/log/logd/lgs_evt.cc:531] -> [staging/src/log/logd/lgs_evt.cc:536]: 
(style) Variable lga_down_rec is reassigned a value before the old one has been 
used.
[staging/src/log/logd/lgs_evt.cc:416]: (style) The scope of the variable 
ckpt_ptr can be reduced.
[staging/src/log/logd/lgs_evt.cc:553]: (style) The scope of the variable stream 
can be reduced.
[staging/src/log/logd/lgs_evt.cc:163]: (error) Mismatching allocation and 
deallocation: client
[staging/src/log/logd/lgs_evt.cc:168]: (error) Mismatching allocation and 
deallocation: client
[staging/src/log/logd/lgs_evt.cc:344]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
[staging/src/log/logd/lgs_filehdl.cc:542]: (style) Variable len is assigned a 
value that is never used.
[staging/src/log/logd/lgs_fmt.cc:560]: (style) The scope of the variable no_ch 
can be reduced.
[staging/src/log/logd/lgs_imm.cc:3478] -> 
[staging/src/log/logd/lgs_imm.cc:3479]: (warning) Either the condition 
attribute!=NULL is redundant or there is possible null pointer dereference: 
attribute.
[staging/src/log/logd/lgs_imm.cc:963]: (style) The scope of the variable i can 
be reduced.
[staging/src/log/logd/lgs_imm.cc:1885]: (style) The scope of the variable 
current_time can be reduced.
[staging/src/log/logd/lgs_imm.cc:1924]: (style) The scope of the variable 
stream can be reduced.
[staging/src/log/logd/lgs_imm.cc:3264]: (style) The scope of the variable 
name_str can be reduced.
[staging/src/log/logd/lgs_imm.cc:3474]: (style) The scope of the variable value 
can be reduced.
[staging/src/log/logd/lgs_imm_gcfg.cc:857] -> 
[staging/src/log/logd/lgs_imm_gcfg.cc:859]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/logd/lgs_imm_gcfg.cc:532]: (style) The scope of the variable 
name_len can be reduced.
[staging/src/log/logd/lgs_imm_gcfg.cc:940]: (style) The scope of the variable 
rc can be reduced.
[staging/src/log/logd/lgs_main.cc:319]: (style) Suspicious condition 
(assignment + comparison); Clarify expression with parentheses.
[staging/src/log/logd/lgs_mbcsv.cc:214]: (style) Suspicious condition 
(assignment + comparison); Clarify expression with parentheses.
[staging/src/log/logd/lgs_mbcsv.cc:541] -> 
[staging/src/log/logd/lgs_mbcsv.cc:551]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/logd/lgs_mbcsv.cc:695] -> 
[staging/src/log/logd/lgs_mbcsv.cc:702]: (style) Variable pheader is reassigned 
a value before the old one has been used.
[staging/src/log/logd/lgs_mbcsv.cc:938] -> 
[staging/src/log/logd/lgs_mbcsv.cc:941]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/logd/lgs_mbcsv.cc:1125] -> 
[staging/src/log/logd/lgs_mbcsv.cc:1148]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/logd/lgs_mbcsv.cc:1875]: (style) Checking if unsigned variable 
clientId is less than zero.
[staging/src/log/logd/lgs_mbcsv.cc:711]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
[staging/src/log/logd/lgs_mds.cc:1003] -> 
[staging/src/log/logd/lgs_mds.cc:1009]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/logd/lgs_stream.cc:416]: (warning) Assignment of function 
parameter has no effect outside the function. Did you forget dereferencing it?
[staging/src/log/logd/lgs_stream.cc:665] -> 
[staging/src/log/logd/lgs_stream.cc:669]: (style) Variable stream is reassigned 
a value before the old one has been used.
[staging/src/log/logd/lgs_stream.cc:1337]: (style) Unsigned variable id cant be 
negative so it is unnecessary to test it.
[staging/src/log/logd/lgs_util.cc:363]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
[staging/src/log/logd/lgs_util.cc:912]: (performance) Prefer prefix ++/-- 
operators for non-primitive types.
[staging/src/log/logd/lgs_config.cc:1854]: (style) The function 
lgs_cfg_read_trace is never used.
[staging/src/log/logd/lgs_util.cc:521]: (style) The function 
lgs_check_path_exists_h is never used.
[staging/src/log/logd/lgs_imm.cc:3234]: (style) The function 
lgs_delete_one_stream_object is never used.
[staging/src/log/logd/lgs_stream.cc:408]: (style) The function 
log_free_stream_resources is never used.
[staging/src/log/logd/lgs_stream.cc:1447]: (style) The function 
log_stream_id_print is never used.
[staging/src/log/logd/lgs_config.cc:1513]: (style) The function 
update_multival_rattr is never used.
(information) Cppcheck cannot find all the include files (use --check-config 
for details)
[staging/src/log/agent/lga_api.c:1104] -> 
[staging/src/log/agent/lga_api.c:1106]: (style) Variable logSvcUsrChars is 
reassigned a value before the old one has been used.
[staging/src/log/agent/lga_mds.c:1408] -> 
[staging/src/log/agent/lga_mds.c:1428]: (style) Variable rc is reassigned a 
value before the old one has been used.
[staging/src/log/agent/lga_mds.c:1219]: (style) The scope of the variable rc 
can be reduced.
[staging/src/log/agent/lga_state.c:412] -> 
[staging/src/log/agent/lga_state.c:421]: (style) Variable ncs_rc is reassigned 
a value before the old one has been used.
[staging/src/log/agent/lga_util.c:312] -> 
[staging/src/log/agent/lga_util.c:317]: (style) Variable client_hdl is 
reassigned a value before the old one has been used.
[staging/src/log/agent/lga_util.c:416]: (style) The function lga_force_shutdown 
is never used.
[staging/src/log/agent/lga_util.c:890]: (style) The function 
logtrace_init_constructor is never used.
[staging/src/log/agent/lga_api.c:419]: (style) The function saLogDispatch is 
never used.
[staging/src/log/agent/lga_api.c:538]: (style) The function saLogFinalize is 
never used.
[staging/src/log/agent/lga_api.c:165]: (style) The function saLogInitialize is 
never used.
[staging/src/log/agent/lga_api.c:1529]: (style) The function saLogLimitGet is 
never used.
[staging/src/log/agent/lga_api.c:351]: (style) The function 
saLogSelectionObjectGet is never used.
[staging/src/log/agent/lga_api.c:1373]: (style) The function saLogStreamClose 
is never used.
[staging/src/log/agent/lga_api.c:1026]: (style) The function 
saLogStreamOpenAsync_2 is never used.
[staging/src/log/agent/lga_api.c:798]: (style) The function saLogStreamOpen_2 
is never used.
[staging/src/log/agent/lga_api.c:1164]: (style) The function saLogWriteLog is 
never used.
[staging/src/log/agent/lga_api.c:1180]: (style) The function saLogWriteLogAsync 
is never used.



---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/opensaf/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets

Reply via email to