- **status**: accepted --> review
- **Milestone**: next --> 5.2.RC1
---
** [tickets:#2341] amf: Fix all Cppcheck 1.77 issues**
**Status:** review
**Milestone:** 5.2.RC1
**Created:** Fri Mar 03, 2017 06:40 AM UTC by A V Mahesh (AVM)
**Last Updated:** Fri Mar 03, 2017 06:45 AM UTC
**Owner:** A V Mahesh (AVM)
[staging/src/amf/amfd/app.cc:285]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfd/apptype.cc:137]: (style) Condition 'rc!=0' is always false
[staging/src/amf/amfd/apptype.cc:69]: (style) The scope of the variable
'sg_type' can be reduced.
[staging/src/amf/amfd/chkop.cc:1297] -> [staging/src/amf/amfd/chkop.cc:1302]:
(style) Variable 'uba' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/ckpt_dec.cc:374] ->
[staging/src/amf/amfd/ckpt_dec.cc:382]: (style) Variable 'status' is reassigned
a value before the old one has been used.
[staging/src/amf/amfd/ckpt_dec.cc:573] ->
[staging/src/amf/amfd/ckpt_dec.cc:577]: (style) Variable 'status' is reassigned
a value before the old one has been used.
[staging/src/amf/amfd/ckpt_dec.cc:1109]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_edu.cc:51] -> [staging/src/amf/amfd/ckpt_edu.cc:56]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/ckpt_enc.cc:2281] ->
[staging/src/amf/amfd/ckpt_enc.cc:2288]: (style) Variable 'status' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/ckpt_enc.cc:2314] ->
[staging/src/amf/amfd/ckpt_enc.cc:2322]: (style) Variable 'status' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/ckpt_enc.cc:1951]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:1982]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2015]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2044]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2076]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2111]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2151]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2176]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2216]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2252]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ckpt_enc.cc:2470]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/clm.cc:344]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/cluster.cc:82]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/cluster.cc:95]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/cluster.cc:116]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/comp.cc:1269] -> [staging/src/amf/amfd/comp.cc:1284]:
(style) Variable 'su_node_ptr' is reassigned a value before the old one has
been used.
[staging/src/amf/amfd/comp.cc:49]: (style) The scope of the variable 'rc' can
be reduced.
[staging/src/amf/amfd/comp.cc:946]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/compcstype.cc:92] ->
[staging/src/amf/amfd/compcstype.cc:99]: (style) Variable 'cst' is reassigned a
value before the old one has been used.
[staging/src/amf/amfd/compcstype.cc:46]: (style) The scope of the variable 'rc'
can be reduced.
[staging/src/amf/amfd/comptype.cc:417]: (style) The scope of the variable 'i'
can be reduced.
[staging/src/amf/amfd/csi.cc:626]: (warning) Comparison of a boolean expression
with an integer.
[staging/src/amf/amfd/csi.cc:1418] -> [staging/src/amf/amfd/csi.cc:1410]:
(warning) Either the condition 'ptr!=nullptr' is redundant or there is possible
null pointer dereference: ptr.
[staging/src/amf/amfd/csi.cc:921] -> [staging/src/amf/amfd/csi.cc:925]: (style)
Variable 'csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/csi.cc:1370] -> [staging/src/amf/amfd/csi.cc:1375]:
(style) Variable 'i_attr' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/csi.cc:1491]: (style) The scope of the variable 'susi'
can be reduced.
[staging/src/amf/amfd/csi.cc:1492]: (style) The scope of the variable 'si' can
be reduced.
[staging/src/amf/amfd/csiattr.cc:541]: (style) The scope of the variable
'attribute' can be reduced.
[staging/src/amf/amfd/ctcstype.cc:120]: (style) Condition 'rc!=0' is always
false
[staging/src/amf/amfd/ctcstype.cc:231] ->
[staging/src/amf/amfd/ctcstype.cc:234]: (style) Variable 'ctcs_type' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/dmsg.cc:236]: (warning) Assignment of function parameter
has no effect outside the function. Did you forget dereferencing it?
[staging/src/amf/amfd/dmsg.cc:61] -> [staging/src/amf/amfd/dmsg.cc:66]: (style)
Variable 'uba' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/hlttype.cc:64]: (style) The scope of the variable 'i' can
be reduced.
[staging/src/amf/amfd/imm.cc:1122] -> [staging/src/amf/amfd/imm.cc:1128]:
(style) Variable 'temp' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2299] -> [staging/src/amf/amfd/imm.cc:2300]:
(style) Variable 'su' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2354] -> [staging/src/amf/amfd/imm.cc:2359]:
(style) Variable 'csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2355] -> [staging/src/amf/amfd/imm.cc:2360]:
(style) Variable 'comp' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2387] -> [staging/src/amf/amfd/imm.cc:2388]:
(style) Variable 'comp' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2478] -> [staging/src/amf/amfd/imm.cc:2487]:
(style) Variable 'csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:2479] -> [staging/src/amf/amfd/imm.cc:2488]:
(style) Variable 'comp' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/imm.cc:1644]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/imm.cc:1891]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/imm.cc:1916]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/imm.cc:1934]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/imm.cc:1942]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/main.cc:257]: (style) The scope of the variable 'n2d_msg'
can be reduced.
[staging/src/amf/amfd/main.cc:290]: (style) The scope of the variable 'n2d_msg'
can be reduced.
[staging/src/amf/amfd/main.cc:323]: (style) The scope of the variable 'n2d_msg'
can be reduced.
[staging/src/amf/amfd/main.cc:405]: (style) The scope of the variable
'queue_evt' can be reduced.
[staging/src/amf/amfd/main.cc:429]: (style) The scope of the variable
'fover_done' can be reduced.
[staging/src/amf/amfd/mds.cc:505] -> [staging/src/amf/amfd/mds.cc:510]: (style)
Variable 'evt' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/ndfsm.cc:116]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:125]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:177]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:225]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:741]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:777]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndfsm.cc:865]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ndproc.cc:1087] -> [staging/src/amf/amfd/ndproc.cc:1089]:
(style) Variable 'valid_info' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/ndproc.cc:303]: (style) The scope of the variable
'state_info_evt' can be reduced.
[staging/src/amf/amfd/ndproc.cc:347]: (style) The scope of the variable
'state_info_evt' can be reduced.
[staging/src/amf/amfd/ndproc.cc:721]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/node.cc:49]: (style) The scope of the variable 'rc' can
be reduced.
[staging/src/amf/amfd/node.cc:68]: (style) The scope of the variable 'rc' can
be reduced.
[staging/src/amf/amfd/node.cc:200]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/node.cc:582]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/node.cc:1555]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/node.cc:1571]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/nodegroup.cc:224]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/nodegroup.cc:1407]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/ntf.cc:492]: (warning) Comparison of a boolean expression
with an integer.
[staging/src/amf/amfd/ntf.cc:697]: (warning) Comparison of a boolean expression
with an integer.
[staging/src/amf/amfd/role.cc:855] -> [staging/src/amf/amfd/role.cc:864]:
(style) Variable 'avnd' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/role.cc:903] -> [staging/src/amf/amfd/role.cc:914]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/role.cc:695]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/role.cc:709]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/role.cc:716]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/role.cc:722]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/role.cc:729]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/role.cc:1124]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/role.cc:1277]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sg.cc:640]: (warning) Comparison of a boolean expression
with an integer.
[staging/src/amf/amfd/sg.cc:640]: (warning) Comparison of a boolean value using
relational operator (<, >, <= or >=).
[staging/src/amf/amfd/sg.cc:929]: (style) Expression is always false because
'else if' condition matches previous condition at line 922.
[staging/src/amf/amfd/sg.cc:394]: (style) Condition 'rc!=0' is always false
[staging/src/amf/amfd/sg.cc:42]: (style) The scope of the variable 'rc' can be
reduced.
[staging/src/amf/amfd/sg.cc:1145]: (style) The scope of the variable 'su' can
be reduced.
[staging/src/amf/amfd/sg.cc:2203]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/sg_2n_fsm.cc:3968] ->
[staging/src/amf/amfd/sg_2n_fsm.cc:3969]: (style) Variable 'a_susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_2n_fsm.cc:2789]: (style) The scope of the variable
'a_susi' can be reduced.
[staging/src/amf/amfd/sg_2n_fsm.cc:2790]: (style) The scope of the variable
'o_su' can be reduced.
[staging/src/amf/amfd/sg_nored_fsm.cc:111]: (style) The scope of the variable
'flag' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:2225] ->
[staging/src/amf/amfd/sg_npm_fsm.cc:2233]: (style) Variable 'susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_npm_fsm.cc:1071]: (style) The scope of the variable
'l_flag' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:1263]: (style) The scope of the variable
'l_flag' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:1391]: (style) The scope of the variable
'a_susi' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:1557]: (style) The scope of the variable
'flag' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:1557]: (style) The scope of the variable
'fover_progress' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:2460]: (style) The scope of the variable
'susi_assgn_failed' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:2831]: (style) The scope of the variable
'o_susi' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:3786]: (style) The scope of the variable
'ot_susi' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:4064]: (style) The scope of the variable
'o_su' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:4065]: (style) The scope of the variable
'o_susi' can be reduced.
[staging/src/amf/amfd/sg_npm_fsm.cc:4189]: (style) The scope of the variable
'rc' can be reduced.
[staging/src/amf/amfd/sg_nway_fsm.cc:1139]: (warning) Assignment of function
parameter has no effect outside the function. Did you forget dereferencing it?
[staging/src/amf/amfd/sg_nway_fsm.cc:147] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:146]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:148] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:146]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:640] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:639]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:641] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:639]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:666] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:665]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:667] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:665]: (warning) Either the condition
'!curr_susi' is redundant or there is possible null pointer dereference:
curr_susi.
[staging/src/amf/amfd/sg_nway_fsm.cc:350] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:355]: (style) Variable 't_susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_nway_fsm.cc:791] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:803]: (style) Variable 'susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_nway_fsm.cc:1255] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:1257]: (style) Variable 'preferred_su' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_nway_fsm.cc:2785] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:2786]: (style) Variable 't_susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_nway_fsm.cc:2864] ->
[staging/src/amf/amfd/sg_nway_fsm.cc:2872]: (style) Variable 't_susi' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sg_nway_fsm.cc:3479]: (style) The scope of the variable
'is_su_present' can be reduced.
[staging/src/amf/amfd/sg_nway_fsm.cc:1285]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sg_nway_fsm.cc:1410]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sg_nwayact_fsm.cc:92]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sgproc.cc:659] -> [staging/src/amf/amfd/sgproc.cc:660]:
(style) Variable 'node' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/sgproc.cc:668] -> [staging/src/amf/amfd/sgproc.cc:669]:
(style) Variable 'node' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/sgproc.cc:1853]: (style) Variable 'num_su' is modified
but its new value is never used.
[staging/src/amf/amfd/sgproc.cc:646]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sgproc.cc:1472]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sgtype.cc:86]: (style) The scope of the variable 'sut'
can be reduced.
[staging/src/amf/amfd/si.cc:165] -> [staging/src/amf/amfd/si.cc:172]: (style)
Variable 'i_csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si.cc:250] -> [staging/src/amf/amfd/si.cc:255]: (style)
Variable 'prev_csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si.cc:249] -> [staging/src/amf/amfd/si.cc:256]: (style)
Variable 'i_csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si.cc:1110] -> [staging/src/amf/amfd/si.cc:1111]: (style)
Variable 'no_of_sisus_to_delete' is reassigned a value before the old one has
been used.
[staging/src/amf/amfd/si.cc:325]: (style) The scope of the variable 'temp' can
be reduced.
[staging/src/amf/amfd/si.cc:385]: (style) The scope of the variable 'rc' can be
reduced.
[staging/src/amf/amfd/si.cc:1490]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:301] -> [staging/src/amf/amfd/si_dep.cc:308]:
(style) Variable 'dep_si' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/si_dep.cc:302] -> [staging/src/amf/amfd/si_dep.cc:314]:
(style) Variable 'spons_si_node' is reassigned a value before the old one has
been used.
[staging/src/amf/amfd/si_dep.cc:442] -> [staging/src/amf/amfd/si_dep.cc:447]:
(style) Variable 'susi' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si_dep.cc:532] -> [staging/src/amf/amfd/si_dep.cc:537]:
(style) Variable 'evt' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si_dep.cc:598] -> [staging/src/amf/amfd/si_dep.cc:605]:
(style) Variable 'si' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si_dep.cc:599] -> [staging/src/amf/amfd/si_dep.cc:606]:
(style) Variable 'spons_si' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/si_dep.cc:856] -> [staging/src/amf/amfd/si_dep.cc:860]:
(style) Variable 'si' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/si_dep.cc:915] -> [staging/src/amf/amfd/si_dep.cc:919]:
(style) Variable 'spons_si' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/si_dep.cc:1617] -> [staging/src/amf/amfd/si_dep.cc:1621]:
(style) Variable 'assignmemt_status' is reassigned a value before the old one
has been used.
[staging/src/amf/amfd/si_dep.cc:978]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:1023]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:1075]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:1470]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:1799]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:2058]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:2130]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:2194]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:2270]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/si_dep.cc:2524]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/siass.cc:1077] -> [staging/src/amf/amfd/siass.cc:1082]:
(style) Variable 'node' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/siass.cc:452]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/siass.cc:473]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/siass.cc:1042]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/sirankedsu.cc:45] ->
[staging/src/amf/amfd/sirankedsu.cc:51]: (style) Variable 'avd_si' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sirankedsu.cc:107] ->
[staging/src/amf/amfd/sirankedsu.cc:113]: (style) Variable 'ranked_su_per_si'
is reassigned a value before the old one has been used.
[staging/src/amf/amfd/sirankedsu.cc:163] ->
[staging/src/amf/amfd/sirankedsu.cc:176]: (style) Variable
'avd_sus_per_si_rank' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/sirankedsu.cc:235] ->
[staging/src/amf/amfd/sirankedsu.cc:245]: (style) Variable 'avd_si' is
reassigned a value before the old one has been used.
[staging/src/amf/amfd/sirankedsu.cc:354]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/su.cc:518]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/su.cc:1943]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/sutype.cc:103]: (style) Condition 'rc!=0' is always false
[staging/src/amf/amfd/util.cc:2022]: (warning) Possible null pointer
dereference: avnd
[staging/src/amf/amfd/util.cc:1272] -> [staging/src/amf/amfd/util.cc:1278]:
(style) Variable 'd2n_msg' is reassigned a value before the old one has been
used.
[staging/src/amf/amfd/util.cc:1566] -> [staging/src/amf/amfd/util.cc:1581]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfd/util.cc:2078]: (style) Consecutive return, break,
continue, goto or throw statements are unnecessary.
[staging/src/amf/amfd/util.cc:1032]: (style) The scope of the variable 'i' can
be reduced.
[staging/src/amf/amfd/util.cc:533]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/util.cc:541]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfd/util.cc:1392]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1408]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1419]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1446]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1465]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1482]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1510]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1526]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/util.cc:1542]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/amf/amfd/tests/test_amfdb.cc:29]: (style) The function 'SetUp' is
never used.
[staging/src/amf/amfd/tests/test_amfdb.cc:33]: (style) The function 'TearDown'
is never used.
[staging/src/amf/amfd/mds.cc:534]: (style) The function 'avd_avnd_mds_send' is
never used.
[staging/src/amf/amfd/ndmsg.cc:177]: (style) The function 'avd_mds_dec_flat' is
never used.
[staging/src/amf/amfd/ndmsg.cc:90]: (style) The function 'avd_mds_enc_flat' is
never used.
[staging/src/amf/amfd/ndfsm.cc:1000]: (style) The function 'avd_node_down' is
never used.
[staging/src/amf/amfd/ntf.cc:108]: (style) The function
'avd_send_cluster_reset_alarm' is never used.
[staging/src/amf/amfd/ntf.cc:343]: (style) The function
'avd_send_su_ha_readiness_state_chg_ntf' is never used.
[staging/src/amf/amfd/util.cc:296]: (style) The function
'avd_snd_oper_state_msg' is never used.
[staging/src/amf/amfd/chkop.cc:132]: (style) The function
'avsv_mbcsv_deregister' is never used.
[staging/src/amf/amfd/chkop.cc:1147]: (style) The function 'avsv_mbcsv_obj_set'
is never used.
[staging/src/amf/amfd/chkop.cc:865]: (style) The function 'avsv_send_ckpt_data'
is never used.
[staging/src/amf/amfd/node.cc:35]: (style) The function 'operator<' is never
used.
[staging/src/amf/amfnd/amfnd.cc:58] -> [staging/src/amf/amfnd/amfnd.cc:63]:
(style) Variable 'del_cbk' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/amfnd.cc:59] -> [staging/src/amf/amfnd/amfnd.cc:65]:
(style) Variable 'o_comp' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/amfnd.cc:191] -> [staging/src/amf/amfnd/amfnd.cc:199]:
(style) Variable 'o_comp' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/amfnd.cc:249] -> [staging/src/amf/amfnd/amfnd.cc:250]:
(style) Variable 'res' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cbq.cc:441] -> [staging/src/amf/amfnd/cbq.cc:442]:
(style) Variable 'temp_csi' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/cbq.cc:734] -> [staging/src/amf/amfnd/cbq.cc:748]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cbq.cc:1132] -> [staging/src/amf/amfnd/cbq.cc:1133]:
(style) Variable 'temp_csi' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/chc.cc:842]: (style) The scope of the variable 'cbk_rec'
can be reduced.
[staging/src/amf/amfnd/clc.cc:609] -> [staging/src/amf/amfnd/clc.cc:615]:
(style) Variable 'clc_evt' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/clc.cc:1695] -> [staging/src/amf/amfnd/clc.cc:1699]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1736] -> [staging/src/amf/amfnd/clc.cc:1740]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1938] -> [staging/src/amf/amfnd/clc.cc:1942]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:2357] -> [staging/src/amf/amfnd/clc.cc:2363]:
(style) Variable 'csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:3039] -> [staging/src/amf/amfnd/clc.cc:3040]:
(style) Variable 'tmp' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:3159] -> [staging/src/amf/amfnd/clc.cc:3168]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1343]: (style) The scope of the variable
'curr_rec' can be reduced.
[staging/src/amf/amfnd/clc.cc:1371]: (style) The scope of the variable
'curr_rec' can be reduced.
[staging/src/amf/amfnd/clc.cc:3029]: (style) The scope of the variable 'i' can
be reduced.
[staging/src/amf/amfnd/comp.cc:2557] -> [staging/src/amf/amfnd/comp.cc:2561]:
(warning) Either the condition 'if(csi&&m_AVND_COMP_IS_ALL_CSI(comp))' is
redundant or there is possible null pointer dereference: csi.
[staging/src/amf/amfnd/comp.cc:2237] -> [staging/src/amf/amfnd/comp.cc:2250]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/comp.cc:2943] -> [staging/src/amf/amfnd/comp.cc:2953]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/compdb.cc:485]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/compdb.cc:486]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/compdb.cc:485]: (warning) Comparison of a boolean value
using relational operator (<, >, <= or >=).
[staging/src/amf/amfnd/compdb.cc:732] -> [staging/src/amf/amfnd/compdb.cc:734]:
(warning) Either the condition '!compt' is redundant or there is possible null
pointer dereference: compt.
[staging/src/amf/amfnd/compdb.cc:718] -> [staging/src/amf/amfnd/compdb.cc:721]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/compdb.cc:1378]: (style) The scope of the variable
'env_counter' can be reduced.
[staging/src/amf/amfnd/cpm.cc:150]: (warning) Assignment of function parameter
has no effect outside the function. Did you forget dereferencing it?
[staging/src/amf/amfnd/cpm.cc:105] -> [staging/src/amf/amfnd/cpm.cc:111]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cpm.cc:141] -> [staging/src/amf/amfnd/cpm.cc:146]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cpm.cc:331] -> [staging/src/amf/amfnd/cpm.cc:346]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1041] -> [staging/src/amf/amfnd/di.cc:1044]:
(warning) Either the condition '!msg' is redundant or there is possible null
pointer dereference: msg.
[staging/src/amf/amfnd/di.cc:1352]: (warning) Possible null pointer
dereference: pending_rec
[staging/src/amf/amfnd/di.cc:999] -> [staging/src/amf/amfnd/di.cc:1015]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1391] -> [staging/src/amf/amfnd/di.cc:1397]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1577]: (style) The scope of the variable 'pg' can
be reduced.
[staging/src/amf/amfnd/err.cc:387] -> [staging/src/amf/amfnd/err.cc:410]:
(warning) Either the condition
'if(comp&&(m_AVND_COMP_PRES_STATE_IS_UNINSTANTIATED(comp)||m_AVND_COMP_PRES_STATE_IS_INSTANTIATIONFAILED(comp)||m_AVND_COMP_PRES_STATE_IS_TERMINATIONFAILED(comp)))'
is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/err.cc:400] -> [staging/src/amf/amfnd/err.cc:410]:
(warning) Either the condition
'if(comp&&(m_AVND_COMP_PRES_STATE_IS_UNINSTANTIATED(comp)||m_AVND_COMP_PRES_STATE_IS_INSTANTIATIONFAILED(comp)||m_AVND_COMP_PRES_STATE_IS_TERMINATIONFAILED(comp)))'
is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/err.cc:314] -> [staging/src/amf/amfnd/err.cc:321]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:661] -> [staging/src/amf/amfnd/err.cc:667]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:689] -> [staging/src/amf/amfnd/err.cc:700]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:780] -> [staging/src/amf/amfnd/err.cc:790]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:917] -> [staging/src/amf/amfnd/err.cc:928]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:1562] -> [staging/src/amf/amfnd/err.cc:1571]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/evt.cc:368] -> [staging/src/amf/amfnd/evt.cc:373]:
(style) Variable 'ha_state_event' is reassigned a value before the old one has
been used.
[staging/src/amf/amfnd/hcdb.cc:73] -> [staging/src/amf/amfnd/hcdb.cc:75]:
(style) Variable 'hc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/hcdb.cc:444] -> [staging/src/amf/amfnd/hcdb.cc:447]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/imm.cc:137] -> [staging/src/amf/amfnd/imm.cc:140]:
(warning) Either the condition 'NCSCC_RC_SUCCESS!=res&&evt_ir' is redundant or
there is possible null pointer dereference: evt_ir.
[staging/src/amf/amfnd/imm.cc:38] -> [staging/src/amf/amfnd/imm.cc:44]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:365] -> [staging/src/amf/amfnd/main.cc:369]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:405] -> [staging/src/amf/amfnd/main.cc:412]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:507]: (style) The scope of the variable
'retry_cnt' can be reduced.
[staging/src/amf/amfnd/mds.cc:104] -> [staging/src/amf/amfnd/mds.cc:107]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:875] -> [staging/src/amf/amfnd/mds.cc:882]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:1549] -> [staging/src/amf/amfnd/mds.cc:1556]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:1587] -> [staging/src/amf/amfnd/mds.cc:1599]:
(style) Variable 'send_info' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/mds.cc:1588] -> [staging/src/amf/amfnd/mds.cc:1600]:
(style) Variable 'send' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:700] -> [staging/src/amf/amfnd/pg.cc:704]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:834] -> [staging/src/amf/amfnd/pg.cc:848]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:66]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:301]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:302]: (style) The scope of the variable 'pg_mem'
can be reduced.
[staging/src/amf/amfnd/pg.cc:400]: (style) The scope of the variable 'pg' can
be reduced.
[staging/src/amf/amfnd/pg.cc:473]: (style) The scope of the variable 'chg_mem'
can be reduced.
[staging/src/amf/amfnd/pg.cc:566]: (style) The scope of the variable 'curr' can
be reduced.
[staging/src/amf/amfnd/pg.cc:738]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:582]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfnd/proxy.cc:332] -> [staging/src/amf/amfnd/proxy.cc:345]:
(style) Variable 'nd_nd_ava_msg' is reassigned a value before the old one has
been used.
[staging/src/amf/amfnd/proxy.cc:646] -> [staging/src/amf/amfnd/proxy.cc:667]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:266] ->
[staging/src/amf/amfnd/proxydb.cc:269]: (warning) Either the condition
'if(comp)' is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/proxydb.cc:45] -> [staging/src/amf/amfnd/proxydb.cc:51]:
(style) Variable 'rec' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:92] -> [staging/src/amf/amfnd/proxydb.cc:98]:
(style) Variable 'rec' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:126] ->
[staging/src/amf/amfnd/proxydb.cc:128]: (style) Variable 'rec' is reassigned a
value before the old one has been used.
[staging/src/amf/amfnd/sidb.cc:851] -> [staging/src/amf/amfnd/sidb.cc:857]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/su.cc:1005] -> [staging/src/amf/amfnd/su.cc:1012]:
(style) Variable 'comp' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/sudb.cc:168] -> [staging/src/amf/amfnd/sudb.cc:167]:
(warning) Either the condition '!su' is redundant or there is possible null
pointer dereference: su.
[staging/src/amf/amfnd/susm.cc:544]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/susm.cc:3774] -> [staging/src/amf/amfnd/susm.cc:3764]:
(warning) Either the condition 'csi' is redundant or there is possible null
pointer dereference: csi.
[staging/src/amf/amfnd/susm.cc:959]: (style) The scope of the variable
'are_si_assigned' can be reduced.
[staging/src/amf/amfnd/susm.cc:1556]: (style) The scope of the variable 'is_en'
can be reduced.
[staging/src/amf/amfnd/susm.cc:2714]: (style) The scope of the variable 'is'
can be reduced.
[staging/src/amf/amfnd/util.cc:191]: (style) The scope of the variable 'str'
can be reduced.
[staging/src/amf/amfnd/sudb.cc:292]: (style) The function 'sudb_rec_comp_add'
is never used.
(information) Cppcheck cannot find all the include files (use --check-config
for details)[staging/src/amf/amfnd/amfnd.cc:58] ->
[staging/src/amf/amfnd/amfnd.cc:63]: (style) Variable 'del_cbk' is reassigned a
value before the old one has been used.
[staging/src/amf/amfnd/amfnd.cc:59] -> [staging/src/amf/amfnd/amfnd.cc:65]:
(style) Variable 'o_comp' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/amfnd.cc:191] -> [staging/src/amf/amfnd/amfnd.cc:199]:
(style) Variable 'o_comp' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/amfnd.cc:249] -> [staging/src/amf/amfnd/amfnd.cc:250]:
(style) Variable 'res' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cbq.cc:441] -> [staging/src/amf/amfnd/cbq.cc:442]:
(style) Variable 'temp_csi' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/cbq.cc:734] -> [staging/src/amf/amfnd/cbq.cc:748]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cbq.cc:1132] -> [staging/src/amf/amfnd/cbq.cc:1133]:
(style) Variable 'temp_csi' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/chc.cc:842]: (style) The scope of the variable 'cbk_rec'
can be reduced.
[staging/src/amf/amfnd/clc.cc:609] -> [staging/src/amf/amfnd/clc.cc:615]:
(style) Variable 'clc_evt' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/clc.cc:1695] -> [staging/src/amf/amfnd/clc.cc:1699]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1736] -> [staging/src/amf/amfnd/clc.cc:1740]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1938] -> [staging/src/amf/amfnd/clc.cc:1942]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:2357] -> [staging/src/amf/amfnd/clc.cc:2363]:
(style) Variable 'csi' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:3039] -> [staging/src/amf/amfnd/clc.cc:3040]:
(style) Variable 'tmp' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:3159] -> [staging/src/amf/amfnd/clc.cc:3168]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/clc.cc:1343]: (style) The scope of the variable
'curr_rec' can be reduced.
[staging/src/amf/amfnd/clc.cc:1371]: (style) The scope of the variable
'curr_rec' can be reduced.
[staging/src/amf/amfnd/clc.cc:3029]: (style) The scope of the variable 'i' can
be reduced.
[staging/src/amf/amfnd/comp.cc:2557] -> [staging/src/amf/amfnd/comp.cc:2561]:
(warning) Either the condition 'if(csi&&m_AVND_COMP_IS_ALL_CSI(comp))' is
redundant or there is possible null pointer dereference: csi.
[staging/src/amf/amfnd/comp.cc:2237] -> [staging/src/amf/amfnd/comp.cc:2250]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/comp.cc:2943] -> [staging/src/amf/amfnd/comp.cc:2953]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/compdb.cc:485]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/compdb.cc:486]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/compdb.cc:485]: (warning) Comparison of a boolean value
using relational operator (<, >, <= or >=).
[staging/src/amf/amfnd/compdb.cc:732] -> [staging/src/amf/amfnd/compdb.cc:734]:
(warning) Either the condition '!compt' is redundant or there is possible null
pointer dereference: compt.
[staging/src/amf/amfnd/compdb.cc:718] -> [staging/src/amf/amfnd/compdb.cc:721]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/compdb.cc:1378]: (style) The scope of the variable
'env_counter' can be reduced.
[staging/src/amf/amfnd/cpm.cc:150]: (warning) Assignment of function parameter
has no effect outside the function. Did you forget dereferencing it?
[staging/src/amf/amfnd/cpm.cc:105] -> [staging/src/amf/amfnd/cpm.cc:111]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cpm.cc:141] -> [staging/src/amf/amfnd/cpm.cc:146]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/cpm.cc:331] -> [staging/src/amf/amfnd/cpm.cc:346]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1041] -> [staging/src/amf/amfnd/di.cc:1044]:
(warning) Either the condition '!msg' is redundant or there is possible null
pointer dereference: msg.
[staging/src/amf/amfnd/di.cc:1352]: (warning) Possible null pointer
dereference: pending_rec
[staging/src/amf/amfnd/di.cc:999] -> [staging/src/amf/amfnd/di.cc:1015]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1391] -> [staging/src/amf/amfnd/di.cc:1397]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/di.cc:1577]: (style) The scope of the variable 'pg' can
be reduced.
[staging/src/amf/amfnd/err.cc:387] -> [staging/src/amf/amfnd/err.cc:410]:
(warning) Either the condition
'if(comp&&(m_AVND_COMP_PRES_STATE_IS_UNINSTANTIATED(comp)||m_AVND_COMP_PRES_STATE_IS_INSTANTIATIONFAILED(comp)||m_AVND_COMP_PRES_STATE_IS_TERMINATIONFAILED(comp)))'
is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/err.cc:400] -> [staging/src/amf/amfnd/err.cc:410]:
(warning) Either the condition
'if(comp&&(m_AVND_COMP_PRES_STATE_IS_UNINSTANTIATED(comp)||m_AVND_COMP_PRES_STATE_IS_INSTANTIATIONFAILED(comp)||m_AVND_COMP_PRES_STATE_IS_TERMINATIONFAILED(comp)))'
is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/err.cc:314] -> [staging/src/amf/amfnd/err.cc:321]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:661] -> [staging/src/amf/amfnd/err.cc:667]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:689] -> [staging/src/amf/amfnd/err.cc:700]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:780] -> [staging/src/amf/amfnd/err.cc:790]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:917] -> [staging/src/amf/amfnd/err.cc:928]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/err.cc:1562] -> [staging/src/amf/amfnd/err.cc:1571]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/evt.cc:368] -> [staging/src/amf/amfnd/evt.cc:373]:
(style) Variable 'ha_state_event' is reassigned a value before the old one has
been used.
[staging/src/amf/amfnd/hcdb.cc:73] -> [staging/src/amf/amfnd/hcdb.cc:75]:
(style) Variable 'hc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/hcdb.cc:444] -> [staging/src/amf/amfnd/hcdb.cc:447]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/imm.cc:137] -> [staging/src/amf/amfnd/imm.cc:140]:
(warning) Either the condition 'NCSCC_RC_SUCCESS!=res&&evt_ir' is redundant or
there is possible null pointer dereference: evt_ir.
[staging/src/amf/amfnd/imm.cc:38] -> [staging/src/amf/amfnd/imm.cc:44]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:365] -> [staging/src/amf/amfnd/main.cc:369]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:405] -> [staging/src/amf/amfnd/main.cc:412]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/main.cc:507]: (style) The scope of the variable
'retry_cnt' can be reduced.
[staging/src/amf/amfnd/mds.cc:104] -> [staging/src/amf/amfnd/mds.cc:107]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:875] -> [staging/src/amf/amfnd/mds.cc:882]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:1549] -> [staging/src/amf/amfnd/mds.cc:1556]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/mds.cc:1587] -> [staging/src/amf/amfnd/mds.cc:1599]:
(style) Variable 'send_info' is reassigned a value before the old one has been
used.
[staging/src/amf/amfnd/mds.cc:1588] -> [staging/src/amf/amfnd/mds.cc:1600]:
(style) Variable 'send' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:700] -> [staging/src/amf/amfnd/pg.cc:704]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:834] -> [staging/src/amf/amfnd/pg.cc:848]: (style)
Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/pg.cc:66]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:301]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:302]: (style) The scope of the variable 'pg_mem'
can be reduced.
[staging/src/amf/amfnd/pg.cc:400]: (style) The scope of the variable 'pg' can
be reduced.
[staging/src/amf/amfnd/pg.cc:473]: (style) The scope of the variable 'chg_mem'
can be reduced.
[staging/src/amf/amfnd/pg.cc:566]: (style) The scope of the variable 'curr' can
be reduced.
[staging/src/amf/amfnd/pg.cc:738]: (style) The scope of the variable 'i' can be
reduced.
[staging/src/amf/amfnd/pg.cc:582]: (performance) Prefer prefix ++/-- operators
for non-primitive types.
[staging/src/amf/amfnd/proxy.cc:332] -> [staging/src/amf/amfnd/proxy.cc:345]:
(style) Variable 'nd_nd_ava_msg' is reassigned a value before the old one has
been used.
[staging/src/amf/amfnd/proxy.cc:646] -> [staging/src/amf/amfnd/proxy.cc:667]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:266] ->
[staging/src/amf/amfnd/proxydb.cc:269]: (warning) Either the condition
'if(comp)' is redundant or there is possible null pointer dereference: comp.
[staging/src/amf/amfnd/proxydb.cc:45] -> [staging/src/amf/amfnd/proxydb.cc:51]:
(style) Variable 'rec' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:92] -> [staging/src/amf/amfnd/proxydb.cc:98]:
(style) Variable 'rec' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/proxydb.cc:126] ->
[staging/src/amf/amfnd/proxydb.cc:128]: (style) Variable 'rec' is reassigned a
value before the old one has been used.
[staging/src/amf/amfnd/sidb.cc:851] -> [staging/src/amf/amfnd/sidb.cc:857]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/su.cc:1005] -> [staging/src/amf/amfnd/su.cc:1012]:
(style) Variable 'comp' is reassigned a value before the old one has been used.
[staging/src/amf/amfnd/sudb.cc:168] -> [staging/src/amf/amfnd/sudb.cc:167]:
(warning) Either the condition '!su' is redundant or there is possible null
pointer dereference: su.
[staging/src/amf/amfnd/susm.cc:544]: (warning) Comparison of a boolean
expression with an integer.
[staging/src/amf/amfnd/susm.cc:3774] -> [staging/src/amf/amfnd/susm.cc:3764]:
(warning) Either the condition 'csi' is redundant or there is possible null
pointer dereference: csi.
[staging/src/amf/amfnd/susm.cc:959]: (style) The scope of the variable
'are_si_assigned' can be reduced.
[staging/src/amf/amfnd/susm.cc:1556]: (style) The scope of the variable 'is_en'
can be reduced.
[staging/src/amf/amfnd/susm.cc:2714]: (style) The scope of the variable 'is'
can be reduced.
[staging/src/amf/amfnd/util.cc:191]: (style) The scope of the variable 'str'
can be reduced.
[staging/src/amf/amfnd/sudb.cc:292]: (style) The function 'sudb_rec_comp_add'
is never used.
[staging/src/amf/agent/ava_hdl.cc:59] -> [staging/src/amf/agent/ava_hdl.cc:67]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/agent/ava_hdl.cc:420]: (style) The scope of the variable 'rec'
can be reduced.
[staging/src/amf/agent/ava_hdl.cc:592]: (style) The scope of the variable 'i'
can be reduced.
[staging/src/amf/agent/ava_mds.cc:86] -> [staging/src/amf/agent/ava_mds.cc:90]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/amf/agent/ava_mds.cc:149] ->
[staging/src/amf/agent/ava_mds.cc:158]: (style) Variable 'rc' is reassigned a
value before the old one has been used.
[staging/src/amf/agent/ava_mds.cc:1020] ->
[staging/src/amf/agent/ava_mds.cc:1028]: (style) Variable 'rc' is reassigned a
value before the old one has been used.
[staging/src/amf/agent/ava_mds.cc:1103] ->
[staging/src/amf/agent/ava_mds.cc:1107]: (style) Variable 'msg' is reassigned a
value before the old one has been used.
[staging/src/amf/agent/ava_op.cc:221] -> [staging/src/amf/agent/ava_op.cc:222]:
(style) Variable 'osaf_cbk.saAmfContainedComponentInstantiateCallback' is
reassigned a value before the old one has been used.
[staging/src/amf/agent/ava_op.cc:240] -> [staging/src/amf/agent/ava_op.cc:241]:
(style) Variable 'osaf_cbk.saAmfContainedComponentInstantiateCallback' is
reassigned a value before the old one has been used.
[staging/src/amf/agent/ava_op.cc:241] -> [staging/src/amf/agent/ava_op.cc:242]:
(style) Variable 'osaf_cbk.saAmfContainedComponentInstantiateCallback' is
reassigned a value before the old one has been used.
[staging/src/amf/agent/ava_op.cc:120]: (style) The scope of the variable 'cb'
can be reduced.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
