- **status**: assigned --> accepted
---
** [tickets:#2342] smf: Fix all Cppcheck 1.77 issues**
**Status:** accepted
**Milestone:** 5.2.RC1
**Created:** Fri Mar 03, 2017 06:46 AM UTC by A V Mahesh (AVM)
**Last Updated:** Fri Mar 03, 2017 06:46 AM UTC
**Owner:** A V Mahesh (AVM)
[staging/src/smf/smfd/SmfCampState.cc:950]: (style) Consecutive return, break,
continue, goto or throw statements are unnecessary.
[staging/src/smf/smfd/SmfCampState.cc:973]: (style) Consecutive return, break,
continue, goto or throw statements are unnecessary.
[staging/src/smf/smfd/SmfCampState.cc:2015]: (style) Consecutive return, break,
continue, goto or throw statements are unnecessary.
[staging/src/smf/smfd/SmfCampState.cc:503]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:510]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:528]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:534]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:544]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:551]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:565]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:594]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:598]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:608]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:622]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:633]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:665]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:679]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:709]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:788]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:845]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:1187]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:1200]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:1817]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampState.cc:1896]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaign.cc:733]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaign.cc:1049]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaign.cc:1081]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaign.cc:1099]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:77]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:88]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:99]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:107]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:115]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:238]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:263]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:284]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:305]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignInit.cc:358]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignThread.cc:262]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/SmfCampaignThread.cc:277]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:75]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:85]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:93]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:103]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:163]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:216]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:281]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCampaignWrapup.cc:311]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfCbkUtil.cc:76]: (style) Expression is always false
because 'else if' condition matches previous condition at line 68.
[staging/src/smf/smfd/SmfCbkUtil.cc:90]: (style) Expression is always false
because 'else if' condition matches previous condition at line 68.
[staging/src/smf/smfd/SmfCbkUtil.cc:90]: (style) Expression is always false
because 'else if' condition matches previous condition at line 76.
[staging/src/smf/smfd/SmfCbkUtil.cc:294]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/SmfExecControlHdl.cc:269]: (style) The scope of the
variable 'p_node_name' can be reduced.
[staging/src/smf/smfd/SmfExecControlHdl.h:47]: (style) class
'SmfExecControlObjHandler' does not have a copy constructor which is
recommended since the class contains a pointer to allocated memory.
[staging/src/smf/smfd/SmfImmOperation.cc:1076] ->
[staging/src/smf/smfd/SmfImmOperation.cc:1077]: (style) Variable 'type' is
reassigned a value before the old one has been used.
[staging/src/smf/smfd/SmfImmOperation.cc:1153]: (style) The scope of the
variable 'attr' can be reduced.
[staging/src/smf/smfd/SmfImmOperation.cc:1154]: (style) The scope of the
variable 'i' can be reduced.
[staging/src/smf/smfd/SmfImmOperation.cc:280]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:358]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:424]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:428]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:563]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:959]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:992]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:1169]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:1304]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfImmOperation.cc:1499]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfLongDnApplier.cc:105]: (performance) Function
parameter 'object_name' should be passed by reference.
[staging/src/smf/smfd/SmfLongDnApplier.cc:107]: (performance) Function
parameter 'attribute_name' should be passed by reference.
[staging/src/smf/smfd/SmfProcState.cc:375]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:477]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:497]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:632]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:860]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:931]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:966]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcState.cc:1011]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfProcedureThread.cc:288]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/SmfProcedureThread.cc:303]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/SmfRollback.cc:271]: (style) The scope of the variable
'attrValueString' can be reduced.
[staging/src/smf/smfd/SmfRollback.cc:384]: (style) The scope of the variable
'attrValueString' can be reduced.
[staging/src/smf/smfd/SmfRollback.cc:200]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfRollback.cc:472]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfRollback.cc:490]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfRollback.cc:535]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfRollback.cc:556]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:1301]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:1336]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:1521]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:1556]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:2066]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfStepTypes.cc:2126]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeAction.cc:230]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeAction.cc:316]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeAction.cc:407]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeAction.cc:455]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeCampaign.cc:332]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeCampaign.cc:358]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeCampaign.cc:370]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeCampaign.cc:375]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeMethod.cc:217]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeMethod.cc:218]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeMethod.cc:232]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeMethod.cc:254]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:634]: (warning) %u in format
string (no. 1) requires 'unsigned int' but the argument type is 'int'.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:692]: (warning) %u in format
string (no. 1) requires 'unsigned int' but the argument type is 'int'.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:746]: (warning) %u in format
string (no. 1) requires 'unsigned int' but the argument type is 'int'.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:4385]: (style) Statements
following return, break, continue, goto or throw will never be executed.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:623]: (style) Unused variable:
activationUnitList
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1451]: (style) Unused variable:
newStepBundleIter
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1589]: (style) Unused variable:
newStepBundleIter
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2003]: (style) Unused variable:
objectList
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2004]: (style) Unused variable:
objit
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2353]: (style) Unused variable:
strIter
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3288]: (style) Unused variable:
stringit
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:858]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:915]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:924]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:948]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:959]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:986]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:995]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1029]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1039]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1058]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1090]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1128]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1137]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1202]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1216]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1284]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1301]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1327]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1334]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1351]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1365]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1371]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1379]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1391]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1401]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1407]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1417]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1459]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1468]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1484]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1503]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1519]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1528]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1544]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1563]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1595]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1602]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1628]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1635]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:1921]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2504]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2606]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2705]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2731]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:2829]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3227]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3248]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3267]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3504]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3569]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3611]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3624]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3675]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3718]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeProcedure.cc:3727]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:858]: (style) Condition 'rc==SA_AIS_OK'
is always true
[staging/src/smf/smfd/SmfUpgradeStep.cc:795]: (style) The scope of the variable
'retry_count' can be reduced.
[staging/src/smf/smfd/SmfUpgradeStep.cc:816]: (style) The scope of the variable
'interval' can be reduced.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2247]: (style) The scope of the
variable 'ret' can be reduced.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1406]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1417]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1430]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1440]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1451]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1464]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1486]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1488]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1490]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUpgradeStep.cc:433]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:461]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1058]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1093]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1214]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1249]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1277]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1283]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1359]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1384]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1423]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:1457]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2434]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2447]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2485]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2610]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2641]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2646]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:2688]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:4000]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUpgradeStep.cc:4114]: (performance) Prefer prefix
++/-- operators for non-primitive types.
[staging/src/smf/smfd/SmfUtils.cc:663]: (performance) Inefficient usage of
string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/SmfUtils.cc:1014]: (performance) Returning the result of
c_str() in a function that returns std::string is slow and redundant.
[staging/src/smf/smfd/SmfUtils.cc:855]: (performance) Prefer prefix ++/--
operators for non-primitive types.
[staging/src/smf/smfd/smfd_campaign_oi.cc:452]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/smfd_campaign_oi.cc:486]: (performance) Inefficient usage
of string::find() in condition; string::compare() would be faster.
[staging/src/smf/smfd/smfd_main.cc:273]: (style) Suspicious condition
(assignment + comparison); Clarify expression with parentheses.
[staging/src/smf/smfd/smfd_mds.c:156] -> [staging/src/smf/smfd/smfd_mds.c:162]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/smf/smfd/smfd_mds.c:184] -> [staging/src/smf/smfd/smfd_mds.c:194]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/smf/smfd/smfd_mds.c:374] -> [staging/src/smf/smfd/smfd_mds.c:387]:
(style) Variable 'rc' is reassigned a value before the old one has been used.
[staging/src/smf/smfd/smfd_smfnd.c:72] ->
[staging/src/smf/smfd/smfd_smfnd.c:75]: (style) Variable 'smfnd' is reassigned
a value before the old one has been used.
[staging/src/smf/smfd/smfd_smfnd.c:119] ->
[staging/src/smf/smfd/smfd_smfnd.c:126]: (style) Variable 'smfnd' is reassigned
a value before the old one has been used.
[staging/src/smf/smfd/smfd_smfnd.c:205] ->
[staging/src/smf/smfd/smfd_smfnd.c:210]: (style) Variable 'smfnd' is reassigned
a value before the old one has been used.
[staging/src/smf/smfd/SmfExecControlHdl.cc:110]: (style) The function
'procExecMode' is never used.
(information) Cppcheck cannot find all the include files (use --check-config
for details)
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
