OpenSC wrote:
#128: Patch: PIV Card update patch
-------------------------+--------------------------------------------------
Reporter: harningt | Owner: opensc-devel@lists.opensc.org
Type: enhancement | Status: new
Priority: normal | Milestone: 0.11.2
Component: opensc | Version: 0.11.1
Severity: normal | Resolution:
Keywords: patch, piv |
-------------------------+--------------------------------------------------
Comment (by harningt):
Attached is a new update to the patch, it accounts for the location of
'malloc' on OSX (stdlib.h, not malloc.h) and cleans up one of the 'hacks'
that I had in place.
according to c99 malloc(3) should be in stdlib.h so this isn't really
a osx issue. Btw: why do include "memory.h" in compression.c ?
The data cache is now properly used by pkcs15-piv in cooperation with the
p15card-helper utility.
Previously a buffer of 8k was allocated for each cert for the PKCS15 data
check, now the cache is used directly for the data.
NOTE: Personalization is ignored by my update. pkcs15-piv does not allow
accessing PubKeys, since they are only accessible at personalization.
Disabling access to PubKeys also enabled pkcs11 to work properly with it,
since when PubKeys are non-existent, certs are used.. otherwise an attempt
to read the PubKey will fail and the cert is ignored.
some first comments: your patch exports a new header file compression
(btw: why export it ? it looks more like an internal header). But the
names used for constanst and functions are very generic. *IF* we want
to export this header file the functions/constants within the file
should have a opensc prefix (i.e. normally "sc_" for functions and "SC_"
for constants). Furthermore it would be nice if the compilation of
compression.c|h is dependent on the presence of zlib support.
Cheers,
Nils
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
