Ludovic Rousseau wrote:
> 2008/10/17 Stanislav Brabec <[EMAIL PROTECTED]>:

> "Fixed" in revision 353.
> http://www.opensc-project.org/pam_pkcs11/changeset/353

Not yet completely. This seems to be critical:

ldap_mapper.c: In function 'ldap_get_certificate':
ldap_mapper.c:760: warning: assignment from incompatible pointer type

ldap_x509[rv] = d2i_X509(NULL, ((const unsigned char **) bv_val), 
bvals[rv]->bv_len);

In case of nss, ldap_x509[rv] is a nss CERTCertificate, d2i_X509 returns
OpenSSL X509 certificate. It cannot work.

d2i_X509() attempts to decode len bytes at *in. If successful a pointer to the 
X509 structure is returned.

It seems, that a rough replacement could be CERT_DecodeDERCertificate or
CERT_DecodeCertificate, but fix needs some coding.

extern CERTCertificate *
CERT_DecodeDERCertificate (SECItem *derSignedCert, PRBool copyDER, char 
*nickname);

> I still have a warning:
> ldap_mapper.c:874: warning: passing argument 2 of 'CERT_CompareCerts'
> discards qualifiers from pointer target type
> 
> This is because we are passing a (const X509 *) in a (X509 *).

It should not cause runtime error.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: [EMAIL PROTECTED]
Lihovarská 1060/12           tel: +420 284 028 966, +49 911 740538747
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to