2009/1/26 Alon Bar-Lev <[email protected]>: > On 1/26/09, Ludovic Rousseau <[email protected]> wrote: >> I patched the OpenSC version of src/ifd/proto-t1.c (patch attached) > > Great! > Thanks you! > >> THIS PATCH DOES NOT WORK. It is just a preview. >> >> Notes: >> - the t1_* functions use a "ifd_protocol_t * prot" parameter but I >> need a "t1_state_t * t1" since some fields are only present in the >> t1_state_t structure >> - t1_negotiate_ifsd() is declared in src/ifd/internal.h and the only >> external source using it is src/ifd/ifd-eutron.c. This function is >> never used elsewhere. This function could be used by the CCID driver >> if the reader does not negotiate the IFSD itself for example >> - I changed my version of proto-t1.c in my CCID handler to make >> comparison more easy >> >> I can integrate some patches from my CCID driver. But integrating all >> the error cases management will be very hard without major changes in >> OpenCT. >> >> What should I do? > > What do you mean "patches from CCID driver"? Other than T1?
I will not commit the patch I sent. The work is not finished. What I propose is to commit only parts of it, the parts that integrate easily in OpenCT. > I only > thought to make the T1 common, so I can compare the CCID > implementation. > Looking ahead, do you think it will be easier to integrate OpenCT CCID > into new framework or your CCID? I think that OpenCT is closer... as > it does not use libusb or daemon. The OpenCT CCID is "very" limited. For example I just discovered it does not negotiate the IFSD (maximum block size supported by the reader) so the card will not send blocks bigger than 32 bytes (default value). I also think it does not support multi-slots readers And it does not support Secure Pin Entry I have never used OpenCT so I can't defend it or its CCID driver. -- Dr. Ludovic Rousseau _______________________________________________ opensc-devel mailing list [email protected] http://www.opensc-project.org/mailman/listinfo/opensc-devel
