From:
https://www.opensc-project.org/openct/browser/trunk/src/ifd/ifd-ccid.c
if ((st->flags & FLAG_NO_SETPARAM) == 0 &&
1182 ((st->flags & FLAG_AUTO_ATRPARSE) == 0 |
1183 proto != IFD_PROTOCOL_T0)) {
The condition check looks confusing. Should the '|' be '||' for clarity?
I am talking about this clause:
(st->flags & FLAG_AUTO_ATRPARSE) == 0 | proto != IFD_PROTOCOL_T0
The precedence of '==' and '!=' is higher than '|', so the code actually
behaves as if '||' was used, but we should correct it for clarity.
Thank you.
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
