Currently no function of internal.h is exported, you may check it out.
It is true that there is some legacy, but it is not a reason to make
more exceptions.
If you like to export it, please move it to appropriate header.

Thanks,
Alon.

On Wed, Apr 15, 2009 at 10:39 AM, Martin Paljak <mar...@paljak.pri.ee>
wrote:
>
> On 15.04.2009, at 10:18, Alon Bar-Lev wrote:
>>
>> Don't do this.
>> You are messing the interface.
>
> True. Unfortunately, to my understanding, OpenSC lacks a "formal" API with
a
> set of defined header files. For example, we have the totally useless EMV
> card driver, emv.h header file which is filesystem garbage and no exports
> for those functions.
> Same applies to compression.h and probably more stuff that ends up in
> include/opensc.
>
>> If the function is in internal.h it should not be used outside OpenSC
>> library.
>
> Logically it belongs with sc_transmit_apdu to opensc.h. Should such low
> level APIs be exported outside of libopensc, or should we limit it to
> pkcs15/card operations?
>
>> If you do want to export it, you should move it to proper include file
>> that is
>> installed on target system.
>
> It might be a good idea to revise the contents of export files and
installed
> header files as a spring cleaning effort.
>
> --
> Martin Paljak
> http://martin.paljak.pri.ee
> +372.515.6495
>
>
>
>
>
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to