Here is a statistic for warnings from opensc code:
4 card-entersafe.c
2 card-myeid.c
19 cardos-tool.c
2 card-piv.c
6 card-westcos.c
1 eidenv.c
12 libtool
2 mechanism.c
2 misc.c
3 muscle.c
13 openssl.c
3 p15emu-westcos.c
2 pkcs11-display.c
4 pkcs11-object.c
6 pkcs15-esteid.c
2 pkcs15-myeid.c
2 pkcs15-tool.c
1 pkcs15-westcos.c
1 slot.c
120 westcos-tool.c
maybe you can have a look at some of them?
hmm, the build logs from the nightly snapshot process are of
little use, I had them build with --enable-strict which creates
a huge amount of extra warnings, too many to dea with in my
opinion. tomorrows build logs should be better (web server: /buildlogs/).
some warnings are ok, the fault isn't ours. for example openssl has ABI
with "int" as parameter for length where we use size_t usualy. not sure
if we should add conversions for each call of such functions.
most other warnings I saw are signedness issues. usualy they are ok
(e.g. u8* vs. char* passed to some print function), but sometimes
the result is wrong (e.g. a function returns an int, then it is stored
in an unsigned int variable, and then the variable is checked "< 0"
which doesn't work out). I think we have no such issues, but maybe
you can have a look.
btw: westcos has most warnings, but about all of them seem to be
signedness warnings with strlen() or strcmp() and passing u8* instead
of char*. maybe there is an easy way to fix this?
Regards, Andreas
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
