Hi.
On 10.11.2009, at 17:02, Mats Andersson wrote:

> This is in stock opensc-0.11.11.
> 
> Smallish bug: (tried mailing b...@opensc-project.org but it failed)
> pkcs15.c:760:
>     Usage of strstr() inverted (works anyway since it’s || and the contents 
> of the if() is mostly harmless, it will mostly be entered of course :-))
Thanks for noticing, fixed.

> By design?
> pkcs15-syn.c:131:
>     Is it “by design” that if builtin_enabled is true and a list is given 
> that it still scans ALL emulators, eventhough the config lists only a few?
>     (specifically is it “by design” that the second if() on line 147 is not 
> an “else if()”?). My first thought was that this config option was to 
> specifically only     include a few of the builtins (and/or “external”)?
No, mistake. Corrected as well in r3819

> Specific feedback/question about EF(DIR) file usage: It could be useful to be 
> able to “by config” inject new AIDs of known applications (i.e. into apps in 
> dir.c) which comply with PKCS15 but that uses EF(DIR) to point to app 
> (whether it’s multiple apps or just non-standard DF). Something planned? 
> Comment?

It would be useful indeed. Especially as there are some extra AID-s already and 
this has been asked by people as well.

-- 
Martin Paljak
http://martin.paljak.pri.ee
+372.515.6495




_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to