Am Donnerstag 11 Februar 2010 13:49:05 schrieb Alon Bar-Lev: > No it isn't... > The generated files should not be cleaned if .tar.gz is used, only if > this is svn checkout, as we assume that we can "make dist" offline.
hu? sorry, I don't understand what your point is. my preference is this: * people should be able to build svn without docs (well, pretty low priority these days, as all distributions have everything needed packaged already) * if documentation is generate during build, it should be gone after "make maintainer-clean" so I get a proper diff between my changed checkout and my unchanged checkout. * if documentation is generated and I run "make dist", it should end up in the tar.gz file, so I can ship the file with pre-generated documentation (similar to autoconf/make/.. files, they are included too). * if people use a tar.gz and run "make clean" or "make distclean" the documentation should not be removed - we didn't change it, we didn't create it, so we shouldn't remove it either. and that last point is the issue: debian build scripts run "make dist-clean" before they generate diffs. with the old Makefile.am/in the pre-generated api.out would be gone. even worse: replaced by a symlink loop, and thus cause a build error, if someone tries to build from the same folder once more. so how do we fix this? if "api.out" is created by makefile, then it should be removed by the makefile. if not, it shouldn't be touched. one - not very nice - way would be to generate documentation from bootstrap script. yes, that looks wrong, but it would put the documentation on the same level as Makefile.in and configure script - all the files we pre-build so they can be included in tar.gz files and are "maintainer" status (i.e. only change if --enable-maintainer and are only deleted with "make maintainer- clean") would be done by the same process. or maybe automake has a mechanism we can hook into? I'm not sure if my fix is right or wrong - so I'm asking. but I'm sure we have a problem. for the distribution I send them a quick fix: "-rm -fr api.out" is replaced by "-rm -f api.out", so it is will delete the "api.out" symlink, but not the "api.out" directory. Regards, Andreas _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
