Martin Paljak wrote:
> On Mar 19, 2010, at 09:39 , Viktor TARASOV wrote:
>   
>> Andreas Jellinghaus wrote:
>>     
>>> I like the change with "struct foo" vs. "foo_t", but also I prefer
>>> variable names in function definitions. but I'm not sure if
>>> that results in problems, if people want to use different names.
>>>
>>> (no need to change, only meant as feedback...)
>>>
>>>       
>> My intention was to homogenize the style at least in the limit of one 
>> source file.
>> I also like parameters in function prototypes -- this way was the shortest.
>> Well, if I'm not the only one who like it, we'll gradually change it.
>>     
> How does this behave with doxygen? There are some comments in pkcs15-init.h, 
> for example create_key has some doxygen comments. 
> Eventually having code comments (and a api doc even if it is for internal 
> use) is admirable.
>   

I'll bear in mind.

-- 
Viktor Tarasov  <viktor.tara...@opentrust.com>

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to