2010/3/30 Andreas Jellinghaus <a...@dungeon.inka.de>:
> Am Sonntag 28 März 2010 22:26:57 schrieb Ludovic Rousseau:
>> Hello,
>>
>> In src/tools/cardos-tool.c line 1157 the function cardos_format()  is
>>  called as: if ((err = cardos_format(opt_startkey))) {
>>
>> But the definitions of cardos_format() are
>> line 502 with OpenSSL
>>   static int cardos_format()
>>
>> line 843 without OpenSSL
>>   static int cardos_format()
>>
>> cardos_format() is called with a startkey parameter but this parameter
>> is not used. What is the correct solution?
>> I think cardos_format() should check the parameter and use it as
>> startkey instead of the default startkey.
>
> attached is a patch to accept the parameter and abort ("not implemented").
> the correct solution of course would be to accept the parameter and evaluate
> it: the user needs to specify a one byte index value "ii" in hex (and we need
> to verify the current startkey has that value), and a 16 byte startkey in hex
> (and we need to use that instead of the 16 byte 0xff default we have).

Committed in revision 4190.

Thanks

-- 
 Dr. Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to