Hello, On Jun 24, 2010, at 12:47 , Andre Zepezauer wrote: > Ludovic Rousseau wrote: >> Why not just remove the lines if they are useless now? >> > Because it makes the process of reviewing much easier. One could apply the > patch local and see the hole context of the pieces which are considered > obsolete. Don't forget that the framework code is complex and simply removing > some lines may have subtle effects.
A patch that can be compared to the original changeset which added the feature [1] would be much easier both to review as well as apply [1] http://www.opensc-project.org/opensc/changeset/1038 -- Martin Paljak http://martin.paljak.pri.ee +3725156495 _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
