Hello,

On Sep 5, 2010, at 9:21 PM, webmas...@opensc-project.org wrote:

> Revision: 4693
> Author:   viktor.tarasov
> Date:     2010-09-05 18:21:43 +0000 (Sun, 05 Sep 2010)
> 
> Log Message:
> -----------
> MyEID: make working change/unblock PIN

The pin_cmd copy is redundant, the attached version should suffice (can't test, 
I don't have my cards with me)

The card_state thing is still wrong, as it is currently driver state, not card 
state. Not that it would matter at once, as probably there will be just one 
incarnation of the driver in pcks15-init context. But it is not correct either.

As a general rule, the amount of copypaste-ish code in drivers needs to be cut 
down for maintainability. 

Attachment: myeid-pin.patch
Description: Binary data


-- 
Martin Paljak
@martinpaljak.net
+3725156495

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to