I see the function parse_slot_id_string in engine_pkcs11.c ends with:

       /* ... or "label_" */
       if (strncmp(slot_id + i, "label_", 6) == 0)
               *slot = n;
               return (*label = strdup(slot_id + i + 6)) != NULL;

       fprintf(stderr, "could not parse string!\n");
       return 0;

in my humble opinion, that is potentially wrong, probably
the intention was to write a parenthesis after the if,
to enclose the return (indenting confirms this!)

       /* ... or "label_" */
       if (strncmp(slot_id + i, "label_", 6) == 0) {
               *slot = n;
               return (*label = strdup(slot_id + i + 6)) != NULL;
       }
       fprintf(stderr, "could not parse string!\n");
       return 0;


 Best regards

  Umberto Rustichelli
  SW engineer & architect
  Secure Edge, Rome - Italy


_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to