Martin Paljak wrote: > Hello, > On Dec 30, 2010, at 3:25 PM, webmas...@opensc-project.org wrote: > > >> Revision: 5005 >> Author: vtarasov >> Date: 2010-12-30 13:25:09 +0000 (Thu, 30 Dec 2010) >> >> Log Message: >> ----------- >> libopensc: API for the 'erase-binary' card operation >> >> =================================================================== >> --- trunk/src/libopensc/opensc.h 2010-12-30 13:20:19 UTC (rev 5004) >> +++ trunk/src/libopensc/opensc.h 2010-12-30 13:25:09 UTC (rev 5005) >> @@ -861,6 +861,17 @@ >> int sc_update_binary(sc_card_t *card, unsigned int idx, const u8 * buf, >> size_t count, unsigned long flags); >> >> +/** >> + * Sets (part of) the content fo an EF to its logical erased state >> + * @param card sc_card_t object on which to issue the command >> + * @param idx index within the file for the data to be erased >> + * @param count number of bytes to erase >> + * @param flags flags for the ERASE BINARY command (currently not used) >> > > Do you think there will be a need for some flags in the foreseeable future? > If there are no flags as of now, the API should not include the flags > parameter (which is actually visible if you follow the path of the unused > flags trail in in the file operations procedures (sc_*_binary). > > Especially because the new wrapper in card-authentic.c does not need any > flags, it just passes them to sc_update_binary. >
No, I do not see such usage in a future. It can be removed. By the way, afais, only PIV card is actually uses 'flags' for sc_update/write_binary. So, 'flags' can also be removed for sc_read_binary. -- Viktor Tarasov <viktor.tara...@opentrust.com> _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
