Martin Paljak wrote:
> Hello,
>
> On Dec 30, 2010, at 4:40 PM, webmas...@opensc-project.org wrote:
>   
>> Revision: 5006
>> Author:   vtarasov
>> Date:     2010-12-30 14:40:28 +0000 (Thu, 30 Dec 2010)
>>
>> Added Paths:
>> -----------
>>    trunk/src/libopensc/authentic.h
>>     
> What about moving the LOGN_ macros to log.h or somewhere central? I 
> personally would not mind having a single debug level and a single debug 
> macro as having the SC_LOG_DEBUG_XXX is not optimal, IMHO.
>   
Readily.
If no objections, I'll do it.


>>    trunk/src/libopensc/card-authentic.c
>>    trunk/src/pkcs15init/pkcs15-authentic.c
>>     
> A semantic mistake in all Oberthur/Authentic related files:
>
> SC_ERROR_MEMORY_FAILURE means "EEPROM error/data corruption on card" (not 
> really used in OpenSC)
> SC_ERROR_OUT_OF_MEMORY should be used for failing memory allocation with 
> malloc/calloc calls.
>   
Ok, thanks.

-- 
Viktor Tarasov  <viktor.tara...@opentrust.com>

_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to