Hello,

On Thu, Jan 27, 2011 at 20:08, Andre Zepezauer
<andre.zepeza...@student.uni-halle.de> wrote:
> Hello Martin,
>
> some comments on r5124:
>
> 1. The values of pin_info->reference and prkey_info->key_reference
> shouldn't be compared because:
>
> * pin_info->reference is used as P2 parameter in VERIFY command
> * prkey_info->key_reference is used in MSE SET tag 0x84

OK, I see your point.
Looking at your patch: could it be extracted into a small lookup
function like the current one that is used? such a small lookup
function with a small doxygen doc would look really nice.

I see it has been working up to because of a coincidence...
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to