Hello,

2011/6/14 Jean-Michel Pouré - GOOZE <jmpo...@gooze.eu>:
>> It is a bug in OpenSC.
>> Patch attached and also available at [1].
>> Martin, please pull my master into your repository.
>> Bye
>> [1]
>> https://github.com/LudovicRousseau/OpenSC/commit/8936901e2b8fade5d9831b224f3313b7b3255133

I wanted to draw attention to the fact that the change can be
downloaded for testing from the Ludovic's mightly build directory on
opensc-project.org [1] by looking for a snapshot with the given commit
ID but then noticed that there's no build available with the given
commit ID. This seems to be because master was merged after the
commit, instead of rebased locally before pushing, which should be the
right way of doing it.

The idea is to be able to provide "usable" packages for bug reporters
or other interested parties to try out possible solutions, without
depending on trunk-sink or having to wait for a release or needing to
work with applying patches. "Please try the included patch" -> "please
try the package/installer with commit ID
8936901e2b8fade5d9831b224f3313b7b3255133" is much more useful for
feedback.

Nevertheless, the build that picked up the latter merge
(40cb1c9e35bc5efc8fd597277f7297261b6ae498) is available and includes
it [2]. Maybe splitting the builds not by user/architecture but by Git
commit would be better idea? Meaning
/downloads/nightly/40cb1c9e35bc5efc8fd597277f7297261b6ae498/opensc-snapshot.tar.gz
etc. as the commit ID is a unique flat namespace. Would require more
work and maybe not be so obvious (seeing incremental output based on
Jenkins build number, which is individual for every builder/tree would
otherwise be helpful). Suggestions on this one?

> Thanks for noticing that.
> Could fix timeout issues for us.

What timeout issues?

> Martin, what do you think of this fix, maybe it should be applied.
It is an obvious bugfix, of course?

I made a snapshot which pull in a bunch of things [3]. There are
issues, like compiler warnings from mentioned changes, so expect
updates. But nevertheless, please try packages with commit ID
6e70c09012f20500d311b618789af2d1120bdda0 from my download folders [4]
(the more I think about it, splitting download directory by commit ID
is the most usable way for such snapshots)



[1] http://www.opensc-project.org/downloads/nightly/ludovic/
[2] 
http://www.opensc-project.org/downloads/nightly/ludovic/tarball/opensc-snapshot-2_40cb1c9e35bc5efc8fd597277f7297261b6ae498.tar.gz
[3] http://martinpaljak.net:8888/view/Martin/job/Martin_continuous_tarball/5/
[4] http://www.opensc-project.org/downloads/nightly/martin/
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to