Thanks, Because I focus on OpenPGP support, I base my branch on Martin's. Some coding convention (from GNU C for example) recommend not to place any space character at the end of lines. I think doing such is a good practice.
Because I just start with this project, I think I should let my modification be considered by 1 core member's branch (Martin for instance) before go to the main branch. On Mon 23 Apr 2012 04:17:21 PM ICT, Ludovic Rousseau wrote: > Le 23 avril 2012 11:09, Nguyễn Hồng Quân <quanngu...@mbm.vn> a écrit : >> Thanks, >> I made a pull request at https://github.com/martinpaljak/OpenSC/pull/19 > > I can't accept your pull request because: > - you cloned martinpaljak/OpenSC instead of OpenSC/OpenSC > - use the staging branch instead of the master branch > - you made a lot of reformat and/or white spaces modifications > > Have a look at https://github.com/martinpaljak/OpenSC/pull/19/files > > Bye > -- Regards, Quân _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
