frederic.comb...@cea.fr wrote:
> Here is my patch (actually, 2 patches that depend if the patch
> concerns only the error 2328 (patch 1) or the whole block
> processing the return value of verify_certificate() (patch 2)).

Patch 1 is obviously incorrect because your change is inside a
conditional.

Patch 2 is the correct change in code flow, but please do not ever
use comments to "remove" source code. The version control system
keeps track of history, and commented out code is very confusing,
not to mention ugly.

It would be great if you sent the change in an easy format. Ludovic
mentioned pull requests. You'll need to know git and github specifics
to do that. If you don't, maybe someone can generate a commit in your
name.


Thanks

//Peter
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to