Hi Gerrit, hi Carsten,
Carsten Neumann wrote:
> Hi Gerrit,
>
>> - osg1.x compat, deprecated support
>> - fcd/lex/bison recreation of src files
>
> personally I don't care too much about this being part of the build,
> having a (python) script that regens them is fine for me.
I would prefer to have it as part of the build, but given that it's a
nontrivial problem that really only shows up extremely rarely, and then
only for people who know what they're doing, a script is probably the
better solution.
>> - osg-config / FindOSG.cmake
>
> trivial remark, but we should call it FindOpenSG.cmake to avoid clash
> with OpenSceneGraph ;)
Yup! :)
> would you mind if I do some reorganization on the build? The thing I
> don't like a lot is that it is hard to figure out which dir goes into
> which lib, because the information is spread over the different files.
> How about putting files CMakeLists.Lib.<name>.txt in Source/ that list
> all directories that belong to that lib (it would also centralize the
> logic for excluding directories depending on available 3rd party
> libs/config options)? The toplevel CMakeLists.txt would just glob for
> those and include them, so adding a new lib does not require changing
> files, just adding one - probably most interesting for contrib stuff.
> Also, IMHO we don't gain much be actually scanning for sources,
> because the generated make build does not automatically trigger a
> rescan, right? So, if we did things a bit more like everybody else
> using cmake we'd actually gain that adding a new source to a
> CMakeLists.txt triggers a regen of the build system. I have a very
> simple python script that generates the file lists, so you could just
> run that to update them.
>
> What do you think ?
Sounds good to me. In general I like the automation that we had, but
again it's a case of something that's needed rarely by people who know
what they're doing. As long as you don't have to manually update file
lists whenever you change something I guess it's ok.
Yours
Dirk
------------------------------------------------------------------------------
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
