Hi Robert, First, we are sorry if no one ever got to your patch in time and would appreciate your understanding that there is no real applying patch system or fixed core developers "patch applying" hours. We do it in amidst of all other kinds of work, and sometimes it coincidentally happens that all core developers are working on something else and are thinking someone else is probably looking at the community patches.
Melanie suggested your presence on IRC to talk to us commiters directly if you think we are taking too long to look at your code. We ask that people do that only if they few they it's taking too long to get a feedback, we don't want to be flooded in "hey, I've got a patch" messages :) Go ahead and ping us, the worst you might get is we can't attend to you at the moment. But out of all the commiters, you should find someone in a coffee break that will probably have the good will (and knowledge in that area) to give you feedback and/or commit. As Melanie mentioned, patches must be made against trunk. If trunk doesn't compile, something is wrong in your machine, because we only submit source code that compiles (it just might not work). So you should be always updating a trunk copy and seeing if it's working. If not, ask around and look in Mantis for the reason. On Thu, 2009-06-11 at 16:01 +0200, Robert Dzikowski wrote: > On Thu, Jun 11, 2009 at 3:02 PM, Melanie<mela...@t-data.com> wrote: > > Hello, > > > > a patch that has a cautionary note and also sports an exception > > dump, wich makes it risky, will normally not go in easily. > > > I don't know what are you talking about, my patch doesn't cause those things. > Exception is thrown on my PC by not modified trunk code (code as it is > in the repository) > when OpenSim server starts, but 0.6.5-post-fixes code runs well on my PC > so there must be sth wrong with the trunk code. That's why I don't > work on trunk code. > > > Also, please do NOT submit patches for post-fixes, any patches that > > you want to have any chance of going in have to be against trunk always. > > > Over a week ago I made a version of my patch for the trunk, but nobody > cared to check it out. > And as I wrote in my previous email, if anybody is interested I will > make updated version of my > patch for the current revision of the trunk. > > > Please make a version against trunk that either has no database > > changes at all, or implements all changes against both SQLite and > > MySQL. That is mandatory for your patch to be considered. > > > My patch doesn't touches database code. There are only comments in > SQLiteRegionData.cs - I would like somebody to explain me why OpenSim > behaves that way. But again there are only comments, you can ignore this file. > > > Please ensure it's tested thoroughly, so it won't eat anyone's babies. > > > All tests pass on trunk code, with one change in one test in > BasicRegionTest.cs, I made this change because this test is badly written > in my opinion. > Besides, my code works correctly in OpenSim server (0.6.5-post-fixes) > and in a viewer. > > > Also, a presence in IRC can halp your case, as you can talk to > > committers there and get the reservations cleared up. > > > Why should I hang out on IRC if nobody cares about my patches. > > > Melanie > > > Thanks for your answer, > robert_d > _______________________________________________ > Opensim-dev mailing list > Opensim-dev@lists.berlios.de > https://lists.berlios.de/mailman/listinfo/opensim-dev _______________________________________________ Opensim-dev mailing list Opensim-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/opensim-dev
