Thanks Michelle. Commented on the Mantis. To be honest, I think it there are variations on region_id that are only used in one spot then they should just be removed, rather than cluttering up the code and suddenly accepting multiple variations everywhere. I think we should only cater for the major region id parameter variations.

On 10/12/11 16:11, Argus wrote:
Justin, could you have a glance at the patched RemoteAdminPlugin.cs I posted in 
Mantis (
http://www.opensimulator.org/mantis/view.php?id=5814 )? I didnt test the code 
yet and there is still some cleaning up to
do, also the summaries need updates...etc...

For all RA function that check for regions I added a new general function 
SceneContainsRegion(). For now all 5 found
versions of region_id would pass through there and also the region_name is then 
available to all RA functions. I also
added a log warning for those region_id parameter that will be deprecated.

Advantage:
- less code
- common error warnings when region not found
- easier to remove deprecated region_id versions
- all RemoteAdmin functions checking scenes use parameters region_id _and_ 
region_name.

Disatvantage:
- a view RA function get a diffrent error message with the same meaning when 
the region is not found

Before I create a patch, I would like to get some feedback if adding the new 
function is the right direction...

NB: I finaly managed to update the RemoteAdmin wiki pages.

Am 10.12.2011 01:46, schrieb Justin Clark-Casey:
Deprecating the parameters in the wiki is a good idea. 6 months is a reasonable 
timeframe in my opinion.

On 09/12/11 18:11, Argus wrote:
I also prefer the region_id. I will post a patch in mantis this weekend adding 
region_id were it was not used...

Just wondering if one might deprecate the non region_id parameters in 6 months 
or so, giving everyone time to adapt. In
that case I would also add a notice to the code? As i am not a dev, i dont know 
what agreements there are on this
subject...



Am 09.12.2011 01:17, schrieb Justin Clark-Casey:
In this case, it wouldn't be so hard to add the facility to take region_id as 
well as region_uuid (or vice versa).
Personally, I feel that region_id is better then region_uuid.

Patches are welcome.

On 08/12/11 21:53, Argus wrote:
You will find these kind of diffrences everywere in opensim, not only with 
region uuid. The problem is, that once its
implemented its not easy to change because someone will already have developed 
something that uses it exactly as it
was
implemented.

Am 08.12.2011 21:56, schrieb R. Gunther:
Hmm, i see its going deep. its also named regionid in the xml files.
Still regionid keeps confusing compared to region_uuid

On 2011-12-08 21:18, R. Gunther wrote:
There are somethings not the same on the wiki remopte admin page.
On the remote admin page with many commands you see regionid others use 
region_uuid
It would be nice and more clear to use with all command the same line 
"region_uuid"
Or there must be a difference between region_uuid and regionid i dotn see.
_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev


_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev


_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev




_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev






_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev


--
Justin Clark-Casey (justincc)
http://justincc.org/blog
http://twitter.com/justincc
_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev

Reply via email to