Darren, Darren J Moffat wrote: > Gerald Jelinek wrote: >> # zoneadm -z myzone attach -u -b IDR246802-01 -b 123456-08 >> >> This new option is brand-specific and only applies to zone brands >> using >> SVr4 packaging. > > Given the above I think "-b" is too generic an option name, particularly > given that SVR4 packing is not the future direction. > > When I saw the case synopsis the first thing that came to mind was that > "-b" was going to mean backup (not really sure what that would mean > though). > > Given that this is brand specific I think we need to make that obvious, > maybe something like this: > > # zoneadm -z myzone attach -u -x patchbackout=IDR246802-01 -x > patchbackout=12345608.
I am not sure how "-x patchbackout" is obviously brand-specific. We can certainly use that as the option name if you feel strongly about it, but there is nothing in the name itself that makes an option brand-specific. This will be visible to the user by the documentation and on-line help. We already have other single-letter options which are brand-specific with the same letter re-used for different brands. We also have "-x param" options which are not brand-specific, so this syntax doesn't mean anything by itself. > I also think it probably makes sense that the list of patches to be > backed out could be take from a file eg: > > # zoneadm -z myzone attach -u -x patchbackoutlist=/tmp/rmpatches > > Don't take the above as actually complying with CLIP or actually fitting > in with the zoneadm CLI they are for illustrative purposes only. > Basically I'm saying don't use a single letter option because this is > brand specific and the second point of patch list in a file. We considered that idea but don't plan on implementing it at this time. This requires extra steps on the part of the user and it doesn't fit the model we have for the use of "update on attach". We expect the user to attempt the attach, see that there are a few problematic patches, then evaluate which ones to backout and which ones to add to the target. If there are so many patches that a file is needed, then the likelihood of the attach working is small. Also, the idea of a wholesale downgrade of the zone is not one we want to encourage. This new option is really just to provide a way to migrate the zone when there are a few patches to deal with. If it turns out that customers really need the ability to backout many patches, we could always add support for a file later. Thanks, Jerry
