Dear LSARC reviewers, please confirm, that the following structure of findbugs package is OK:
/usr/bin/*findbugs* /usr/share/doc/*findbugs* /usr/share/doc/*findbugs*/LICENSE.txt /usr/share/doc/*findbugs*/README.txt /usr/share/doc/*findbugs*/<html-documents> /usr/share/doc/*findbugs*/manual/<html-documents> /usr/share/*findbugs* /usr/share/*findbugs*/bin /usr/share/*findbugs*/bin/addMessages /usr/share/*findbugs*/bin/computeBugHistory /usr/share/*findbugs*/bin/convertXmlToText /usr/share/*findbugs*/bin/copyBuggySource /usr/share/*findbugs*/bin/defectDensity /usr/share/*findbugs*/bin/deprecated /usr/share/*findbugs*/bin/deprecated/bugHistory /usr/share/*findbugs*/bin/deprecated/unionBugs /usr/share/*findbugs*/bin/deprecated/unionResults /usr/share/*findbugs*/bin/deprecated/updateBugs /usr/share/*findbugs*/bin/fbwrap /usr/share/*findbugs*/bin/filterBugs /usr/share/*findbugs*/bin/*findbugs* /usr/share/*findbugs*/bin/*findbugs2* /usr/share/*findbugs*/bin/listBugDatabaseInfo /usr/share/*findbugs*/bin/mineBugHistory /usr/share/*findbugs*/bin/printAppVersion /usr/share/*findbugs*/bin/printClass /usr/share/*findbugs*/bin/rejarForAnalysis /usr/share/*findbugs*/bin/setBugDatabaseInfo /usr/share/*findbugs*/bin/unionBugs /usr/share/*findbugs*/bin/xpathFind /usr/share/lib/java/*findbugs* /usr/share/lib/java/*findbugs*/lib /usr/share/lib/java/*findbugs*/lib/annotations-1.3.4.jar /usr/share/lib/java/*findbugs*/lib/asm-3.1.jar /usr/share/lib/java/*findbugs*/lib/asm-analysis-3.1.jar /usr/share/lib/java/*findbugs*/lib/asm-commons-3.1.jar /usr/share/lib/java/*findbugs*/lib/asm-tree-3.1.jar /usr/share/lib/java/*findbugs*/lib/asm-util-3.1.jar /usr/share/lib/java/*findbugs*/lib/asm-xml-3.1.jar /usr/share/lib/java/*findbugs*/lib/bcel-5.3.jar /usr/share/lib/java/*findbugs*/lib/dom4j-1.6.1.jar /usr/share/lib/java/*findbugs*/lib/*findbugs*-1.3.4.jar /usr/share/lib/java/*findbugs*/lib/*findbugs*-ant-1.3.4.jar /usr/share/lib/java/*findbugs*/lib/*findbugs*-ant.jar -> *findbugs*-ant-1.3.4.jar /usr/share/lib/java/*findbugs*/lib/*findbugs*.jar -> *findbugs*-1.3.4.jar /usr/share/lib/java/*findbugs*/lib/jaxen-1.1.1.jar /usr/share/lib/java/*findbugs*/lib/jsr-305.jar You can see that all jar libraries have version number, so there should be no clashes. The only exception is jsr-305.jar, where I'm not sure if it has any version number... Can you advice? Or should I assign any artificial number (like 1.0)? Also please see two links (finbugs.jar, and findbugs-ant.jar that point to the latest version of finbugs (if any external application wants to use findbugs)... Please let me know if the package structure is OK. What else should I do to finish this LSARC review? Thanks, Petr Jim Walker wrote: > Tom Childers wrote: >> Hello, Petr. >> >> Is that an acceptable solution? -tdc >> >> On Dec 9, 2008, at 11:14 AM, Danek Duvall wrote: >> >>> On Tue, Dec 09, 2008 at 11:01:31AM -0800, Tom Childers wrote: >>> >>>> Looking at this case, which has been sitting for a couple of >>>> weeks, I realize that Petr has raised an issue that we need to >>>> clarify. If we use links in /usr/share/java to point to the most >>>> recent version of each component, and underlying components can >>>> be delivered by different packages, then links may get changed >>>> and cause things to break. >>>> >>>> Can we simply assume that IPS handles this situation correctly? If >>>> so, are we requiring that all of these FOSS projects going >>>> into OpenSolaris use IPS? >>> >>> Those links need each to be delivered exactly once on a system, by >>> just one package. No packaging system can deal with a single file >>> being delivered multiple times by conflicting package developers. >>> >>> I'd suggest that projects either directly use the versioned jar >>> file that's most appropriate for their needs, or install a symlink >>> in a private directory to the jar file they need, and put that in >>> their classpath. Perhaps there are other alternatives, too. >>> >>> Danek >> > > Right. The versioned jar files should be stable, only the junit.jar > sym link will change over time. > > /usr/share/lib/java/junit.jar link to most recent version > /usr/share/lib/java/junit-4.5.jar > /usr/share/lib/java/junit-3.8.2.jar > > Mengwei plans to integrate junit-4.5 soon (c-team review is tomorrow). > > Petr, > > Does findbugs work with junit-4.5? > > Cheers, > Jim
